[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: toppred and bowtie now reproducible



Hi Sascha,

thanks as always for your effort.

On Thu, May 26, 2016 at 06:00:32AM +0100, Sascha Steinbiss wrote:
> I’ve made toppred and bowtie reproducible and also did the usual housekeeping (hardening, autopkgtests, …). In git and svn, respectively.

I've uploaded toppred.

I've looked at bowtie and I have a question:  In the reproducible.patch
you set some varying variables to fixed (basically empty) values in the
Makefile.  In addition you are also commenting the variables inside the
code which might also hide other information like build options etc.  I
wonder whether the latter is needed.  There might be users who are
interested in those settings like Build Options and other things.  I
assume that the Build Options are fixed for a reproducible build, aren't
they?

So what about

    -DBUILD_HOST="\"Debian-reproducible\""

and inject

    dpkg-parsechangelog --show-field Date

into -DBUILD_TIME.  I also wonder whether the string

    gcc -v 2>&1 | tail -1 | sed 's/ *(.*//'

should be generic enough to solve the reproducible issue by beeing
informative enough for the user.

What do you think?

Kind regards

    Andreas.

-- 
http://fam-tille.de


Reply to: