Re: Post-Receive Hooks
Hi James,
thanks for your investigation. I'd welcome if you fix the issues you've
found in a manner looking sensible to you. If you need permissions for
those repositories you can not access please ping the according team.
Kind regards
Andreas.
On Wed, Apr 27, 2016 at 11:20:02PM +0100, James Clarke wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> Hi,
> I noticed the other day that some debian-astro repositories were using
> the debian-science post-receive hooks, rather than their own, leading to
> things like deb.li links posted by KB in #debian-science pointing to
> non-existent repositories. This prompted me to look through all the
> repositories in debian-astro, debichem, debian-med and debian-science,
> tabulating the results to see how consistent they are. The results vary
> between the different teams, and are attached file, but here is a
> summary of my findings:
>
> 1. A lot of debian-astro packages are calling debian-science's
> post-receive. This seems like a bad thing to do, especially given
> debian-astro has its own post-receive that seems to have been forked
> from debian-science (though may need updating, along with the KGB
> config).
>
> 2. Many packages lack any post-receive hooks. This is easy to fix, and I
> can't think of any reasons why this would be preferable for public
> repositories.
>
> 3. Many packages just call /usr/local/bin/git-commit-notice. Given each
> team has its own post-receive hook which does this, I again see no
> good reason for these not to use the correct hook.
>
> i. A few call git-post-receive-tag-pending as well (via pee(1)). I
> doubt maintainers would be very happy if this was done for every
> package, even though I am strongly in favour of the script (or forks
> thereof).
>
> 4. As you might expect, there are a few special snowflakes, including a
> few which I lack permission to read.
>
> 5. The official Debian Science policy is quite outdated when it comes to
> the section on repositories[1]. It has no mention of the
> setup-repository script, and encourages people to use
> /usr/local/bin/git-commit-notice, rather than
> debian-science-post-receive. If people are ok with it, I would be
> willing to update this.
>
> Regards,
> James
>
> [1] http://debian-science.alioth.debian.org/debian-science-policy.html#idm46065384004448
> -----BEGIN PGP SIGNATURE-----
>
> iQIcBAEBCgAGBQJXITsVAAoJELGTdwwYahx938kP/2MDVQZLSiS11pP6lcT9Sh6i
> 9AEIc6NegBy1Z9PYs2y0wpJaM+e5Nl17uCl8xFimWmrrR+LZV3b61maMuX6PU+5S
> suGB3aClbTVIMe/C2VhF883aYZRacPzZjwGYkHkti8fgUuRV3IWyTOIWdaddu7DX
> khXBoay7zrU2P0dnO4HaiWVFKzPbEEvHUuSZ9HyZedC1MJkMn6RzddTxd+7ruiLl
> 6p+7+FTKO3qCwcNesJLYGIBsl+V8U4zvYnaU+iRv7qWmqtwuR/amoWGCXivbGHjE
> skHi0ESuHYEiGbvQfXKe+6FDGGlMR+BuPtt7a2pKaJ6KQH6NPBkyhdQybG64AGEg
> +fD9J++OpczsWyDIGueComlY37+Yob05M2YQrAis9Th3P8TapTwY/kbuEGnexZtH
> XPRUTIPiAzGjzY3ChEmeP+yIB1JppEa/KTRvK1D7pCXCiAwedDRpRVrWtFhNGBBH
> 1peCA7g13Bdinxi2M8eHML9fvEZ7lWkLR1sDile0g01FtF/8WnGqT7Zz4XrZfIGz
> iPkQKO4kH2v7RouVN1+OiEb/0cCTILBB0RhIVwQkguOpspp5rocZJLKw3gNAmYwP
> OSVlzmL9GUCYhwR78joVGEG48ILa3QNXaZzY8BDhExEa6kJJQsHxqDGGHBzoEavB
> CXfJpgab+6yDgwIF+3v2
> =p5BY
> -----END PGP SIGNATURE-----
> Debian Science and Related Teams - Post-Receive Hooks (2016-04-27)
> =====================================================
>
> Debian Astro
> ------------
>
> aplpy.git No post-receive hook
> astlib.git No post-receive hook
> astromatic.git No post-receive hook
> astrometry-data-2mass.git No post-receive hook
> astrometry.net.git No post-receive hook
> astroml-addons.git No post-receive hook
> astroml.git No post-receive hook
> astroquery.git No post-receive hook
> astroscrappy.git No post-receive hook
> casacore-data.git No post-receive hook
> casacore.git No post-receive hook
> ccdproc.git No post-receive hook
> coyote.git No post-receive hook
> cpl.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-amber.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-fors.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-giraf.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-hawki.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-kmos.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-muse.git No post-receive hook
> cpl-plugin-naco.git No post-receive hook
> cpl-plugin-sinfo.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-template.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-uves.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-vimos.git /home/groups/debian-science/bin/debian-science-post-receive
> cpl-plugin-visir.git No post-receive hook
> cpl-plugin-xsh.git /home/groups/debian-science/bin/debian-science-post-receive
> crush.git No post-receive hook
> debian-astro.git No post-receive hook
> emcee.git No post-receive hook
> erfa.git /home/groups/debian-science/bin/debian-science-post-receive
> eso-midas.git /home/groups/debian-science/bin/debian-science-post-receive
> eso-pipelines.git No post-receive hook
> esorex.git /home/groups/debian-science/bin/debian-science-post-receive
> fitscut.git No post-receive hook
> fitspng.git No post-receive hook
> fitsverify.git /home/groups/debian-science/bin/debian-science-post-receive
> ftools-fv.git /home/groups/debian-science/bin/debian-science-post-receive
> funtools.git /home/groups/debian-science/bin/debian-science-post-receive
> gadget2.git No post-receive hook
> gammapy.git No post-receive hook
> glue.git No post-receive hook
> gnudatalanguage.git No post-receive hook
> gravit.git No post-receive hook
> gyoto.git /home/groups/debian-science/bin/debian-science-post-receive
> iausofa.git /home/groups/debian-science/bin/debian-science-post-receive
> idlastro.git No post-receive hook
> iraf.git /home/groups/debian-science/bin/debian-science-post-receive
> jsamp.git No post-receive hook
> missfits.git No post-receive hook
> montage.git No post-receive hook
> montage-wrapper.git No post-receive hook
> mpfit.git No post-receive hook
> neat.git No post-receive hook
> photutils.git No post-receive hook
> psfex.git No post-receive hook
> pyavm.git No post-receive hook
> pyephem.git No post-receive hook
> pyregion.git No post-receive hook
> pysynphot.git No post-receive hook
> python-asdf.git No post-receive hook
> python-astropy-affiliated.git No post-receive hook
> python-astropy.git /home/groups/debian-astro/bin/debian-astro-post-receive
> python-astropy-helpers.git No post-receive hook
> python-cpl.git /home/groups/debian-science/bin/debian-science-post-receive
> python-fitsio.git No post-receive hook
> python-pyds9.git /home/groups/debian-science/bin/debian-science-post-receive
> python-pyraf.git /home/groups/debian-science/bin/debian-science-post-receive
> python-pywcs.git /home/groups/debian-science/bin/debian-science-post-receive
> rawtran.git No post-receive hook
> reproject.git No post-receive hook
> saods9.git /home/groups/debian-science/bin/debian-science-post-receive
> scamp.git No post-receive hook
> sextractor.git /home/groups/debian-science/bin/debian-science-post-receive
> siril.git No post-receive hook
> skycat.git /home/groups/debian-science/bin/debian-science-post-receive
> spectral-cube.git No post-receive hook
> specutils.git No post-receive hook
> splash.git No post-receive hook
> starlink-ast.git /home/groups/debian-science/bin/debian-science-post-receive
> starlink-pal.git /home/groups/debian-science/bin/debian-science-post-receive
> stellarium.git exec /usr/local/bin/git-commit-notice
> stellarium-legacy.git No post-receive hook
> stellarium-stars.git exec /usr/local/bin/git-commit-notice
> stiff.git No post-receive hook
> sunpy.git No post-receive hook
> swarp.git No post-receive hook
> tcl-fitstcl.git /home/groups/debian-science/bin/debian-science-post-receive
> tycho2.git No post-receive hook
> wcsaxes.git No post-receive hook
> wcslib.git /home/groups/debian-science/bin/debian-science-post-receive
> wcstools.git /home/groups/debian-science/bin/debian-science-post-receive
> weightwatcher.git No post-receive hook
> x11iraf.git /home/groups/debian-science/bin/debian-science-post-receive
> xpa.git /home/groups/debian-science/bin/debian-science-post-receive
> yorick-yao.git exec /usr/local/bin/git-commit-notice
> yt.git No post-receive hook
>
> Summary
> -------
>
> 59 No post-receive hook
> 34 /home/groups/debian-science/bin/debian-science-post-receive
> 3 exec /usr/local/bin/git-commit-notice
> 1 /home/groups/debian-astro/bin/debian-astro-post-receive
> --
> 97
> --
>
> DebiChem
> --------
>
> biceps.git exec /git/debian-med/git-commit-notice
> chemps2.git No post-receive hook
> comet-ms.git /home/groups/debichem/bin/debichem-post-receive
> gpaw.git No post-receive hook
> gpaw-setups.git /home/groups/debian-science/bin/debian-science-post-receive
> hekate.git /home/groups/debichem/bin/debichem-post-receive
> lhendraw.git No post-receive hook
> libmasstoolkit.git No post-receive hook
> libpwiz.git exec /usr/local/bin/git-commit-notice
> libwildmagic.git /home/groups/debichem/bin/debichem-post-receive
> lutefisk.git exec /usr/local/bin/git-commit-notice
> masschroq.git exec /usr/local/bin/git-commit-notice
> massxpert.git exec /usr/local/bin/git-commit-notice
> mmass.git exec /usr/local/bin/git-commit-notice
> molequeue.git /home/groups/debichem/bin/debichem-post-receive
> openmm.git /home/groups/debichem/bin/debichem-post-receive
> openms.git exec /usr/local/bin/git-commit-notice
> p4vasp.git exec /usr/local/bin/git-commit-notice
> python-ase.git /home/groups/debichem/bin/debichem-post-receive
> python-griddataformats.git No post-receive hook
> python-mdanalysis.git No post-receive hook
> python-mzml.git exec /usr/local/bin/git-commit-notice
> r-cran-base64enc.git exec /usr/local/bin/git-commit-notice
> r-cran-downloader.git exec /usr/local/bin/git-commit-notice
> r-cran-maldiquantforeign.git exec /usr/local/bin/git-commit-notice
> r-cran-maldiquant.git exec /usr/local/bin/git-commit-notice
> r-cran-mixtools.git /home/groups/debichem/bin/debichem-post-receive
> r-cran-readbrukerflexdata.git exec /usr/local/bin/git-commit-notice
> r-cran-readmzxmldata.git exec /usr/local/bin/git-commit-notice
> r-other-amsmercury.git /home/groups/debichem/bin/debichem-post-receive
> r-other-curvefdp.git /home/groups/debichem/bin/debichem-post-receive
> r-other-iwrlars.git /home/groups/debichem/bin/debichem-post-receive
> r-other-nitpick.git /home/groups/debichem/bin/debichem-post-receive
> tandem-mass.git exec /usr/local/bin/git-commit-notice
> viewmol.git /home/groups/debichem/bin/debichem-post-receive
>
> Summary
> -------
>
> 15 exec /usr/local/bin/git-commit-notice
> 12 /home/groups/debichem/bin/debichem-post-receive
> 6 No post-receive hook
> 1 /home/groups/debian-science/bin/debian-science-post-receive
> 1 exec /git/debian-med/git-commit-notice
> --
> 35
> --
>
> Debian Med
> ----------
>
> (Repositories that call /git/debian-med/git-commit-notice are omitted)
>
> debian-med.git No post-receive hook
> emboss.git exec /usr/local/bin/git-commit-notice
> igv.git No post-receive hook
> ncbi-tools6.git No post-receive hook
> pesco.git No post-receive hook
> samtools.git exec /usr/local/bin/git-commit-notice
> sitplus.git exec /usr/local/bin/git-commit-notice
> users/corentin-guest.git No post-receive hook
> users/sergiodj-guest.git No post-receive hook
> users/spectra.git Cannot read post-receive hook (permission denied)
>
> Summary
> -------
> 402 exec /git/debian-med/git-commit-notice
> 6 No post-receive hook
> 3 exec /usr/local/bin/git-commit-notice
> 1 Cannot read post-receive hook (permission denied)
> ---
> 412
> ---
>
> Debian Science
> --------------
>
> (Repositories that call debian-science-post-receive are omitted)
>
> adk2tool.git No post-receive hook
> adolc.git No post-receive hook
> ape.git exec /usr/local/bin/git-commit-notice
> apertium-cat.git exec /usr/local/bin/git-commit-notice
> apertium-dan.git exec /usr/local/bin/git-commit-notice
> apertium-fra.git exec /usr/local/bin/git-commit-notice
> apertium.git exec /usr/local/bin/git-commit-notice
> apertium-nno.git exec /usr/local/bin/git-commit-notice
> apertium-nno-nob.git exec /usr/local/bin/git-commit-notice
> apertium-nob.git exec /usr/local/bin/git-commit-notice
> apertium-sme-nob.git exec /usr/local/bin/git-commit-notice
> apertium-swe.git exec /usr/local/bin/git-commit-notice
> arduino-mk.git No post-receive hook
> ask.git No post-receive hook
> atompaw.git exec /usr/local/bin/git-commit-notice
> bliss.git No post-receive hook
> bossa.git No post-receive hook
> cbflib.git Functionally empty post-receive hook (just comments)
> ccd.git No post-receive hook
> ceres-solver.git No post-receive hook
> cg3.git exec /usr/local/bin/git-commit-notice
> ckon.git exec /usr/local/bin/git-commit-notice
> coinmp.git No post-receive hook
> colpack.git No post-receive hook
> dx.git exec /usr/local/bin/git-commit-notice
> dxsamples.git exec /usr/local/bin/git-commit-notice
> eigen2.git exec /git/pkg-kde/git-commit-notice
> elmer-doc.git exec /usr/local/bin/git-commit-notice
> engrid.git exec /usr/local/bin/git-commit-notice
> fcl.git No post-receive hook
> flintqs.git No post-receive hook
> foma.git exec /usr/local/bin/git-commit-notice
> gavodachs.git No post-receive hook
> geneagrapher.git exec /usr/local/bin/git-commit-notice
> gfm.git exec /usr/local/bin/git-commit-notice
> giac.git Calls /usr/local/bin/git-post-receive-tag-pending, and the seemingly non-existent /usr/local/bin/git-post-receive-diff?
> giella-core.git exec /usr/local/bin/git-commit-notice
> giella-sme.git exec /usr/local/bin/git-commit-notice
> gpaw.git No post-receive hook
> gummi.git exec pee /usr/local/bin/git-commit-notice /usr/local/bin/git-post-receive-tag-pending
> h5py.git exec /usr/local/bin/git-commit-notice
> hfst.git exec /usr/local/bin/git-commit-notice
> hfst-ospell.git exec /usr/local/bin/git-commit-notice
> hmat-oss.git No post-receive hook
> ismrmrd.old.git exec /usr/local/bin/git-commit-notice
> kst.git exec /usr/local/bin/git-commit-notice
> libfox95.git exec /usr/local/bin/git-commit-notice
> libticables.git exec /usr/local/bin/git-commit-notice
> libticalcs.git exec /usr/local/bin/git-commit-notice
> libticonv.git exec /usr/local/bin/git-commit-notice
> libtifiles.git exec /usr/local/bin/git-commit-notice
> libvigraimpex.git exec pee /usr/local/bin/git-commit-notice /usr/local/bin/git-post-receive-tag-pending
> linop.git exec /usr/local/bin/git-commit-notice
> linsmith.git exec /usr/local/bin/git-commit-notice
> lttoolbox.git exec /usr/local/bin/git-commit-notice
> mathicgb.git exec /usr/local/bin/git-commit-notice
> mathic.git exec /usr/local/bin/git-commit-notice
> netcdfc.git No post-receive hook
> nfft.git exec /usr/local/bin/git-commit-notice
> nltk.git exec pee /usr/local/bin/git-commit-notice /usr/local/bin/git-post-receive-tag-pending
> nufft.git exec /usr/local/bin/git-commit-notice
> o2scl.git exec /usr/local/bin/git-commit-notice
> octomap.git No post-receive hook
> openctm.git No post-receive hook
> opencv.git No post-receive hook
> pfft.git exec /usr/local/bin/git-commit-notice
> pnfft.git exec /usr/local/bin/git-commit-notice
> pyfftw.git exec /usr/local/bin/git-commit-notice
> pynfft.git exec /usr/local/bin/git-commit-notice
> pyoperators.git exec /usr/local/bin/git-commit-notice
> python-expyriment.git No post-receive hook
> quadrule.git exec /usr/local/bin/git-commit-notice
> qucs.git No post-receive hook
> rbdl.git No post-receive hook
> r-cran-gbm.git No post-receive hook
> r-cran-lhs.git No post-receive hook
> r-cran-pbdzmq.git No post-receive hook
> r-cran-r6.git No post-receive hook
> r-cran-tgp.git No post-receive hook
> r-cran-uuid.git No post-receive hook
> r-cran-vcdextra.git No post-receive hook
> rubiks.git No post-receive hook
> sagemath-database-combinatorial-designs.git No post-receive hook
> scatterplot3d.git exec /usr/local/bin/git-commit-notice
> scoop.git exec pee /usr/local/bin/git-commit-notice /usr/local/bin/git-post-receive-tag-pending
> spglib.git exec /usr/local/bin/git-commit-notice
> stp.git No post-receive hook
> su2.git exec /usr/local/bin/git-commit-notice
> svgtoipe.git No post-receive hook
> sympy.git No post-receive hook
> syrthes.git Calls /usr/local/bin/git-post-receive-tag-pending, and the seemingly non-existent /usr/local/bin/git-post-receive-diff?
> tiemu.git exec /usr/local/bin/git-commit-notice
> tilem.git exec /usr/local/bin/git-commit-notice
> tilp2.git exec /usr/local/bin/git-commit-notice
> toulbar2.git exec /usr/local/bin/git-commit-notice
> travatar.git No post-receive hook
> ufo-core.git Can't read; permission denied (actual repo is in debian-pan, this is just a symlink)
> vishnu.git No post-receive hook
> wannier90.git exec /usr/local/bin/git-commit-notice
> xmds2.git exec /usr/local/bin/git-commit-notice
> yoda.git exec /usr/local/bin/git-commit-notice
> yorick-gy.git No post-receive hook
> yorick-yao.git exec /usr/local/bin/git-commit-notice
> yorick-ygsl.git exec /usr/local/bin/git-commit-notice
> yorick-ynfft.git No post-receive hook
>
> Summary
> -------
>
> 681 exec /home/groups/debian-science/bin/debian-science-post-receive (including without exec)
> 58 exec /usr/local/bin/git-commit-notice
> 38 No post-receive hook
> 4 exec pee /usr/local/bin/git-commit-notice /usr/local/bin/git-post-receive-tag-pending
> 2 Calls /usr/local/bin/git-post-receive-tag-pending, and the seemingly non-existent /usr/local/bin/git-post-receive-diff?
> 1 exec /git/pkg-kde/git-commit-notice
> 1 Can't read; permission denied (actual repo is in debian-pan, this is just a symlink)
> 1 Functionally empty post-receive hook (just comments)
> ---
> 786
> ---
--
http://fam-tille.de
Reply to: