Re: [MoM] regarding rename_binary_result.patch
Hi Malihe,
I noticed another issue. In the pristine-tar branch the old tarball name
remains. I'd recommend to reimport the new tarball name
gbp import-orig --pristine-tar <PATH>/king-probe_2.13.110909.orig.tar.xz
it might be needed to delete the upstream tag but might be it works
without this.
Hope this helps
Andreas.
On Mon, Aug 10, 2015 at 01:47:23PM +0200, Andreas Tille wrote:
> Hi Malihe,
>
> I observed your commits (without trying to build since I' just sitting
> in the train to debconf). I noticed that for the binary rename you
> decided for a patch to the makefile. At first I'd say that this is
> perfectly OK since everything that works is OK here. However, when I
> did similar things I instead decided to do the rename inside
> debian/rules in something like
>
> override_dh_install:
> dh_install
> mv debian/$(DEBPKGNAME)/usr/bin/probe debian/$(DEBPKGNAME)/usr/bin/king-probe
>
> like way. While it is simply a matter of tast and there is no right or
> wrong way I'd like to express this option to let you know.
>
> I might send further remarks when I try to build the package later but
> it looks like you are easily making your way which makes me really
> happy. :-)
>
> Kind regards
>
> Andreas.
>
> --
> http://fam-tille.de
>
>
> --
> To UNSUBSCRIBE, email to debian-med-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: [🔎] 20150810114723.GQ25265@an3as.eu">https://lists.debian.org/[🔎] 20150810114723.GQ25265@an3as.eu
>
>
--
http://fam-tille.de
Reply to: