[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Sponsorship request: snap-aligner





On Tue, Sep 29, 2015 at 11:02 PM Michael Crusoe <michael.crusoe@gmail.com> wrote:
On Tue, Sep 29, 2015 at 10:03 PM Charles Plessy <plessy@debian.org> wrote:
Le Wed, Sep 30, 2015 at 03:42:27AM +0000, Michael Crusoe a écrit :
> gbp clone git://anonscm.debian.org/debian-med/snap-aligner.git

Hi Michael,

I found non-Free statements in some files under import/pdclibhdfs/src/,
for example:

* TITLE: TstReadHdfs.tdprj.xml                                               *
*                                                                            *
* Copyright 2009-2010 by Teradata Corporation.                               *
*                                                                            *
* ALL RIGHTS RESERVED.                                                       *
*                                                                            *
* TERADATA CONFIDENTIAL AND TRADE SECRET

That would make the files unredistributable, but I guess it is just a honest
mistake ?  Can you investigate this further ?

Thank you for catching that. They are not used to build, so I've stripped them out using Files-excluded in debian/copyright.

Alas, I just discovered that tests/bin/ValidateSamFile.jar doesn't contain its source code and is used by tests/datatest.py & tests/filetest.py so I've removed that as well and added a patch to not use it.

I locally patched the scripts to use picard-tools to run ValidateSamFile but those scripts turn out to not work and aren't used by the build system anyway. 

The unit tests that are compiled and run still function without them.

I've pushed up a commit that removes my patch. The jar is still stripped from the orig tarball.
 

Should be ready to go now.


Have a nice day,

Thanks!
 

--
Charles Plessy
Debian Med packaging team,
http://www.debian.org/devel/debian-med
Tsurumi, Kanagawa, Japan

Reply to: