[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: gcc-5 transition of GDCM



Hi Sébastien,

Great work!


On August 6, 2015 04:28:37 PM Sébastien Jodogne wrote:

> Sorry for the multiple posts, but thanks to Steve's upload of gccxml last
> evening, I have finally managed to make the transition of the gdcm package
> to gcc-5. A single patch to the CMake scripts is necessary [1].

Hmm..  The patch points out a couple of deficiencies with my script (now fixed).  

But it also points out the way to simply replace gccxml by castxml.  So I 
updated your patch to do that.

Unfortunately, I get a build failure with gdcm:

[ 72%] Generating csharp/vtkGDCMImageReader-sentinel.txt
cd /home/steve/Packages/gdcm/build-area/gdcm-2.4.4/obj-x86_64-linux-
gnu/Utilities/VTK && /usr/bin/mummy --suppress-warnings 6005 6006 6009 6010 
6012 6013 6015 6016 6017 6018 6019 --settings-file 
/home/steve/Packages/gdcm/build-area/gdcm-2.4.4/obj-x86_64-linux-
gnu/Utilities/VTK/xml/MummySettings.xml --gccxml-file 
/home/steve/Packages/gdcm/build-area/gdcm-2.4.4/obj-x86_64-linux-
gnu/Utilities/VTK/xml/vtkGDCMImageReader.xml --csharp-file 
/home/steve/Packages/gdcm/build-area/gdcm-2.4.4/obj-x86_64-linux-
gnu/Utilities/VTK/csharp/vtkGDCMImageReader.cs --export-layer-file 
/home/steve/Packages/gdcm/build-area/gdcm-2.4.4/obj-x86_64-linux-
gnu/Utilities/VTK/export-layer/vtkGDCMImageReaderEL.cxx
ERROR: In 
/tmp/buildd/cableswig-0.1.0+cvs20111009/Cable/Parsers/cableFundamentalType.cxx, 
line 99
FundamentalType (0x302a3c0): Invalid type name "__int128" for FundamentalType.

ERROR: In 
/tmp/buildd/cableswig-0.1.0+cvs20111009/Cable/Parsers/cableXMLSourceParser.cxx, 
line 138
XMLSourceParser (0x1f43b30): Error creating source representation.

# (0): error: m5008: MummyApplication::ProcessSource
Utilities/VTK/CMakeFiles/vtkgdcmGenerateWrappers.dir/build.make:70: recipe for 
target 'Utilities/VTK/csharp/vtkGDCMImageReader-sentinel.txt' failed


How did you avoid the "__int128" problem?  I'm building on adm64 in an up-to-
date sid chroot.


> Andreas, would it be possible for you to review this change and, possibly,
> close #777868 and #791508 if the requirements are met?

The patch looks good to me.  Just need to resolve the build problem.

Thanks,
-Steve

Attachment: signature.asc
Description: This is a digitally signed message part.


Reply to: