On Sat, 2015-07-25 at 14:01 -0500, Steve M. Robbins wrote: > Paul: thanks for this! > > > On July 25, 2015 01:21:33 PM Paul Novotny wrote: > > On Fri, 2015-07-24 at 19:34 -0500, Steve Robbins wrote: > > > Sure! Commit away. > > > > K, I commited it. I moved the code I had in debian/update.sh to get > > -orig-source in debian/rules. That seems to follow more what I have > > seen in debian-med. > > Sure, that's fine. Just a comment about the final line of get-orig > -source: > > cd $(DESTDIR) && mv `ls InsightData*.tar.xz` > insighttoolkit$(VER_MAJOR)_$(VERSION).orig-data.tar.xz && cd - > > First, the final "&& cd ~" is unnecessary: each line in a makefile > target is > evaluated in its own shell so the next line will have "forgotten" > about the > directory change. > > Second, I'm wary of the wildcards here. I might have downloaded > manually some > of the data files in their original names. This would do surprising > things > (actually I think it will fail) if `ls InsightData*.tar.xz` expands > to more > than one file. Since we have all the version data in variables, > can't we do > something more like the following? > > cd $(DESTDIR) && mv InsightData-$(VERSION).tar.xz > insighttoolkit$(VER_MAJOR)_$(VERSION).orig-data.tar.xz > > Thirdly, $(DESTDIR) is a generic name, and -- though I can see in the > context > of "uscan" it makes sense -- in the broader context the name is more > often > used for the destination of "make install". How about TARBALLDIR? > > > > Also, I renamed the ExternalData directory to data. > > I'm fine with that change. > > > > Just so the source file would be insighttoolkit4_4.8.0.orig > > -data.tar.xz. I thought I read these files should be all lower > > case, is > > that correct? > > I have never read that. I was successfully using uppercase > (insighttoolkit4_4.8.0.orig-ExternalData.tar.xz), so I don't think > there's a > problem with case. > > But like I say, using "data" is fine with me. Thanks for the feedback. I implemented the changes, and just commited them. -Paul
Attachment:
signature.asc
Description: This is a digitally signed message part