Re: fasttree: hard-coded limit on branch length precision leads to erroneous results
>>>>> "A" == Andreas Tille <andreas@an3as.eu> writes:
A> Hi Roland, On Thu, Mar 26, 2015 at 04:04:23PM +0100, Roland
A> Fehrenbacher wrote:
>> as described in detail at
>> http://darlinglab.org/blog/2015/03/23/not-so-fast-fasttree.html
>> fasttree 2.1.7 has a a serious issue for many genomic
>> epidemiology studies which can lead to completely wrong
>> conclusions about research results in biomedicine. The current
>> version of fasttree in jessie (2.1.7-1) has this severe
>> deficiency.
>>
>> The above article describes the patch needed to prevent the
>> flaw. Upstream incorporated the fix in version 2.1.8. In my
>> opinion this bug is release critical and should be fixed before
>> the release of jessie.
A> Please file an RC bug!
>> I've already prepared a patched new package for this, so the bug
>> could be closed very fast after uploading that new package
>> version.
A> Please note that a fixed package should not change anything
A> but the bug (so the Vcs fields should remain untouched for
A> the upload!).
I haven't changed the Vcs fields in the tagged commit (from which the
fixed package would be built), but just pushed a new commit with the Vcs
fields changed to GIT, so that the GIT repo is consistent from now on.
Andreas> Thanks for noticing
Sometimes Twitter can be helpful (I caught it there and as a
scientist I thought this needs to be fixed right away to prevent other
researchers from having unwarranted dreams of a nobel prize :) ... or
even faulty drugs being created, whatsoever)
Roland
-------
http://www.q-leap.com / http://qlustar.com
--- HPC / Storage / Cloud Linux Cluster OS ---
Reply to: