On Mon Feb 09 2015 at 11:02:39 PM Andreas Tille <
andreas@an3as.eu> wrote:
Hi Michael,
On Mon, Feb 09, 2015 at 04:06:12PM +0000, Michael Crusoe wrote:
>
> Howdy from Romania!
Cool. I never was i Romania. :-)
> >
> > 1. DEP3 autopkgtest:
> > I tried to add a test script in debian/test which should reproduce
> > the call done in dh_auto_test. Unfortunately it fails. I assume
> > this is easy to solve for you.
> >
>
> diff --git a/debian/tests/control b/debian/tests/control
> new file mode 100644
> index 0000000..1160776
> --- /dev/null
> +++ b/debian/tests/control
> @@ -0,0 +1,3 @@
> +Tests: run-unit-test
> +Depends: @, python-drmaa
>
> Why python-drmaa? This isn't a dependency of ours.
Cut-n-pasto removed (please gbp-pull)
Thanks.
> Yeah, the tests break because the scripts are in a different location. I'll
> develop a patch.
Good.
I've fixed it without having to make a quilt patch.
> > Could you please make up your mind whether we could save the code copy
> > since we actually have the identical version number (I did not checked
> > the code!) packaged.
> >
>
> Sadly we must use our copy as we made local changes: specifically:
>
> 'core/include/seqan/seq_io/sequence_stream_impl.h: don't memory map
> plain FAST[AQ]
> files' (from third-party/seqan/ChangeLog)
>
> This was reported upstream: https://github.com/seqan/seqan/issues/720 and
> we told that "[they] will not update the 1.4.x version of SeqAn, though.
> Your problems will go away with our upcoming 2.0 release that will also
> turbocharge your I/O. I hope that's OK."
OK. Can you please add this information in README.source and also add a
paragraph for the seqan code copy to debian/copyright?
Done.
Ready for re-review.
Kind regards
Andreas.
--
http://fam-tille.de