Test suite of flexbar 2.4 does not work properly
Hi Johannes,
I was testing the Debian package of flexbar 2.4 and noticed the
following problem:
$ LC_ALL=C flexbar_test_csfastq.sh
Specified quality format is unknown!
diff: result_right.csfastq: No such file or directory
Test 1 OK
Specified quality format is unknown!
diff: result_left.csfastq: No such file or directory
Test 2 OK
Specified quality format is unknown!
diff: result_any.csfastq: No such file or directory
Test 3 OK
Specified quality format is unknown!
diff: result_left_tail.csfastq: No such file or directory
Test 4 OK
Specified quality format is unknown!
diff: result_right_tail.csfastq: No such file or directory
Test 5 OK
Despite the fact that the test does fail it sais OK. You can prevent
this by setting '-e' option as we are doing this in the patch for Debian
Med[1] which I would strongly recommend. I also noted that your
verification method about success or failure is wrong and fixed this in
[1] as well. Moreover I noticed that the paramater you are delivering
to the --format option has changed in this version - this is also fixed
in [1].
Finally the only thing I had no idea how to fix are the
flexbar_test_csfast?.sh tests. Could you please verify this before you
release the next version of flexbar?
Kind regards and thanks for providing flexbar as free software
Andreas.
[1] http://anonscm.debian.org/viewvc/debian-med/trunk/packages/flexbar/trunk/debian/patches/add_shebang_to_tests.patch?view=markup
--
http://fam-tille.de
Reply to: