[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [ucko@debian.org: Bug#735596: snp-sites: FTBFS: FAIL: run-all-tests]



Sorry again for PM.
Too eager.

Hey Andreas,

On Tue, Jan 21, 2014 at 9:52 AM, Andreas Tille <andreas@an3as.eu> wrote:
Hi Jorge,

On Tue, Jan 21, 2014 at 09:41:54AM +0000, Jorge Sebastião Soares wrote:
> I am already subscribed, but thanks for forwarding it to me as I don't
> check that filter very often.
> Sascha has pointed me to this resource:
>
> http://qa.debian.org/developer.php
>
> To monitor the package progression.

OK.

;)
 
> Again, debugging snp-sites with Sascha, we have made significant changes to
> the upstream code which are now committed to the upstream git repo.

I'm happy to see another of various cases where injecting a package into
Debian has leaded to an enhancement of the code quality. :-)

Hehe!
And also for me to learn a bit of C! Win win.
 

> I have tagged version 1.4 with these changes.
> I have also tested the upstream code in a 32bit Debian VM and it all
> compiles fine now.
>
> Sascha told me that I need to do some changes to the changelog file
> (confirming that the bug has been fixed), commit those changes to the
> debian git repo and that that should close the open bug.
>
> Can you confirm this?

I confirm this ans I'm waiting for your `git push` to check the changes
and upload.

So before I upload, do I just

dch -i 'closes bug 735596'

Then change the snp-sites upstream version from 1.3 to 1.4 in the changelog;
Copy the files that actually changed to the debian git local repo;
gbp against 1.4;

If everything ok, commit changes and upload pristine tarball?

Regards,

Jorge


On Tue, Jan 21, 2014 at 10:01 AM, Jorge Sebastião Soares <j.s.soares@gmail.com> wrote:
Hey Andreas,

On Tue, Jan 21, 2014 at 9:52 AM, Andreas Tille <andreas@an3as.eu> wrote:
Hi Jorge,

On Tue, Jan 21, 2014 at 09:41:54AM +0000, Jorge Sebastião Soares wrote:
> I am already subscribed, but thanks for forwarding it to me as I don't
> check that filter very often.
> Sascha has pointed me to this resource:
>
> http://qa.debian.org/developer.php
>
> To monitor the package progression.

OK.

;)
 
> Again, debugging snp-sites with Sascha, we have made significant changes to
> the upstream code which are now committed to the upstream git repo.

I'm happy to see another of various cases where injecting a package into
Debian has leaded to an enhancement of the code quality. :-)

Hehe!
And also for me to learn a bit of C! Win win.
 

> I have tagged version 1.4 with these changes.
> I have also tested the upstream code in a 32bit Debian VM and it all
> compiles fine now.
>
> Sascha told me that I need to do some changes to the changelog file
> (confirming that the bug has been fixed), commit those changes to the
> debian git repo and that that should close the open bug.
>
> Can you confirm this?

I confirm this ans I'm waiting for your `git push` to check the changes
and upload.

So before I upload, do I just

dch -i 'closes bug 735596'

Then change the snp-sites upstream version from 1.3 to 1.4 in the changelog;
Copy the files that actually changed to the debian git local repo;
gbp against 1.4;

If everything ok, commit changes and upload pristine tarball?

Regards,

Jorge
 



Reply to: