[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#728797: ITP: python-mne -- Python modules for MEG and EEG data analysis



Hi Alexandre,

On Thu, Nov 21, 2013 at 05:40:44PM +0100, Alexandre Gramfort wrote:
> > enough.
> 
> gramfort@tsilinuxd74> git import-orig --pristine-tar
> ../mne-python_0.7rc1.orig.tar.gz

In my first mail about the RC candidate I suggested the version

    mne-python_0.7~rc1.orig.tar.gz

(please mind the '~').  I'm not sure whether git supports this character
in its tags but please note that this is important for the following
reason:

$ if dpkg --compare-versions 0.7~rc1 gt 0.6  ; then echo "0.7~rc1 is greater than 0.6";  fi
0.7~rc1 is greater than 0.6
$ if dpkg --compare-versions 0.7~rc1 gt 0.7  ; then echo "0.7~rc1 is greater than 0.7"; else echo "FAILURE: 0.7~rc1 is NOT GREATER than 0.7";  fi
FAILURE: 0.7~rc1 is NOT GREATER than 0.7
$ if dpkg --compare-versions 0.7rc1 gt 0.7  ; then echo "0.7rc1 is greater than 0.7"; else echo "FAILURE: 0.7rc1 is NOT GREATER than 0.7";  fi
0.7rc1 is greater than 0.7


So we need to make sure that dpkg considers your release candidate a
smaller version than the final release and thus we need to use 0.7~rc1
... at least for the Debian packaging.  This could be ironed out in
d/watch by using dversionmangle - but as long as there is no final
upload and we are targeting at 0.7 for the first upload anyway there
is no point in beeing to picky.  Just to let you know why I'm using
0.7~rc1 below!
 
> ~/work/src/debian/mne-python
> What is the upstream version? [0.7rc1]
> gbp:info: Importing '../mne-python_0.7rc1.orig.tar.gz' to branch 'upstream'...
> gbp:info: Source package is mne-python
> gbp:info: Upstream version is 0.7rc1
> gbp:error: Couldn't commit to 'pristine-tar' with upstream 'upstream':
> Execution failed: [Errno 2] No such file or directory
> gbp:error: Import of ../mne-python_0.7rc1.orig.tar.gz failed

Hmmm, besides the fact that I did renamed the tarball to

   mne-python_0.7~rc1.orig.tar.gz

this worked for me.  Did you verified that the file you try to import
really exists? 

> what should be my upstream repo?

The tarball simply needs to exist - no real magic otherwise.  Worked for
me like a charm.

> I just used:
> 
> gbp-clone ssh://git.debian.org/git/debian-med/mne-python.git
> 
> should :
> 
> ssh://git.debian.org/git/debian-med/mne-python.git
> 
> be my upstream and master?

If you used gbp-clone above you should get

(master) $ git branch
* master
  pristine-tar
  upstream

This is the usual git-buildpackage layout we are using in Debian Med
team.
 
> >> > When trying this I realised that for running the tests the Build-Depends
> >> > python-coverage was missing.
> >>
> >> I added now :
> >>
> >> python-coverage
> >
> > I thought I would have commited this to the repository I was talking
> > about (git://git.debian.org/git/debian-med/mne-python.git).
> 
> does it mean I need to have a debian branch on github that is
> the master on debian.org?

As I tried to make clear in our initial conversation the repository on
git.debian.org and your upstream repository on github are not really
interconnected via Git.  We simply import some tarball by fully ignoring
that it is originated from some Git repository.  It is simply a tarball
and we are (as a consequence) ignoring all the history inbetween the
released tarballs.  As I told you there are pros and cons of this method
but this generic way has proven to work nicely in the past.

In short:  If I'm talking about "the" Git repository I always mean

   ssh://git.debian.org/git/debian-med/mne-python.git
 
> send me a private message to find a way to chat if it's easier/faster.

If needed you can reach me via jabber at tillea@gmail.com .  Another
chance would be IRC at OFTC channel #debian-med - but I have no access
to IRC on business hours and you need to ping me in advance if you
want to IRC with me.
 
In any case I have imported 0.7~rc1 and pushed the changes.  Please pull
and have a look.  I tried to be verbose in commit logs.  In any case you
should enhance the long description.  A minimum text would be what you
injected in the ITP bug #728797 - a bit more would be nice.

You get this kind of information when you call

   lintian -i -I <pkgname>_<debversion>_<arch>.changes

Feel free to continue bothering us with questions if something remains
unclear.

Kind regards

        Andreas.

-- 
http://fam-tille.de


Reply to: