[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: ITP: HTSeq



Hi Diane,

thanks for working on this.

On Wed, Jul 31, 2013 at 01:47:39PM -0700, Diane Trout wrote:
> > Just push to alioth and I'll check from there.  This enables others from
> > the team to commit slight changess - sometimes it is more easy to just
> > apply a change than to describe what should be changed.
> 
> Packaging pushed to git://git.debian.org/debian-med/python-htseq.git

I gbp-cloned this but get

$ git-buildpackage
make -C src clean
make[1]: Entering directory `/home/tillea/debian-maintain/alioth/debian-med_git/python-htseq/src'
rm -f StepVector_wrap.cxx ../HTSeq/StepVector.py _HTSeq.c
make[1]: Leaving directory `/home/tillea/debian-maintain/alioth/debian-med_git/python-htseq/src'
rm -rf dist build MANIFEST
dh_clean
gbp:error: You have uncommitted changes in your source tree:
gbp:error: # On branch master
# Changes not staged for commit:
#   (use "git add/rm <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#       deleted:    HTSeq/StepVector.py
#       deleted:    src/StepVector_wrap.cxx
#       deleted:    src/_HTSeq.c
#
no changes added to commit (use "git add" and/or "git commit -a")

gbp:error: Use --git-ignore-new to ignore.
 

So the only way to properly build is using `gbp-clone --git-ignore-new`
which is a bit nasty.  The reason for this is that the clean target does
something else but restoring the original.  I could imagine that the
Debian Python team might have some experience with things like this and
knows a good way to work around.  IMHO git-buildpackage is terribly
picky about things like this and autobuilders (or (p)debuild) are more
tollerant.  But I'd be happy if this could be solved before we do a final
upload if time permits.

Two additional remarks:  If you have *really* good contacts to upstream
you can start nitpicking and might give them a hint about the lintian
info (which you get via lintian -I) about

I: python-htseq: spelling-error-in-manpage usr/share/man/man1/htseq-count.1.gz allows to allows one to
I: python-htseq: spelling-error-in-manpage usr/share/man/man1/htseq-count.1.gz mroe more

I sometimes give those hints to upstream to make them aware that Debian
cares about their software and to get in stronger contact.  I do not do
this in every case - it depends whether time permits.

The other thing is that I noticed you have implemented means to rename
original upstream version 0.5.4p3 to 0.5.4.3 per uversionmangle in
d/watch.  I just want to mention that leaving the 'p' inside the version
string would be perfectly OK.  There is no rule that enforces numbers
and '.' exclusively.  Feel free to leave it as it is currently if you
have your reasons to do so - I just want to mention that it is not
needed and in some case it could lead to confusions.

The next step would be to file an ITP bug report.  Do you want to do
this yourself or do you want me to do this (on behalf of the team - so
the package wil remain yours).

Thanks again for your work on this

     Andreas.

-- 
http://fam-tille.de


Reply to: