Re: Bug#689041: RFS: orthanc/0.2.1-3 [ITP] -- Lightweight, RESTful DICOM server for healthcare and medical research
On Mon, Oct 08, 2012 at 06:19:20PM +0200, Sebastien Jodogne wrote:
> >override_dh_auto_install:
> > cp $(CURDIR)/Build/Orthanc $(CURDIR)/debian/orthanc/usr/bin/orthanc
> > gzip -c -9 $(CURDIR)/NEWS >
> >$(CURDIR)/debian/orthanc/usr/share/doc/orthanc/changelog.gz
> >
> >What were you trying to do ?
>
> The "cp" command is used to convert the name of the binary to
> lowercase. The camel case naming in the upstream package is a
> convention I use for Windows builds.
OK.
> The "gzip" command is used to install the upstream changelog.
This should rather be done using
override_dh_installchangelogs
> There are certainly better ways of doing so, unfortunately this is
> my first Debian packaging attempt :)
That's perfectly fine - its our pleasure to teach you to finally enhance
our team.
> >Also I'll remove -DDEBIAN_HARDENING=ON on the next upload, I just do
> >not understand why it was used in the case of an explicit debian
> >packaging...
>
> Indeed, this flag is not required on Debian sid. I have implemented
> this flag to allow backporting to squeeze, whose debhelper version
> is apparently not able to natively cope with hardening.
That's OK in principle - if I'm not totally missleaded it does not harm
in sid and if it is helpful for backporting (I'm not really sure if this
is actually the case) it might remain.
> >Not running the test suite is not a good idea.
>
> I have been obliged to do so, since it seems that the "libgtest-dev"
> package does not come with the required shared library.
Filing a bug report against libgtest-dev?
> I could
> however easily modify the CMake files to statically link against
> gtest (only for the test suite of course).
This might help to successfully run the test suite however, what you
would test in this case is not what finally will end up inside the
package so the point of running the test suite is not fullfilled.
> >Finally, I would not use -DCMAKE_BUILD_TYPE=Debug, maybe something
> >like MinSizeRel would be slightly better (-O2)
>
> I have indeed forgotten to replace "Debug" with "Release".
>
> I will submit the last three modifications tomorrow morning. I will
> warn you when I will have done so.
>
> I will also try and close the ITP and the RFS bugs tomorrow.
As Matthieu said this is not needed.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: