Re: Bug#689041: RFS: orthanc/0.2.1-3 [ITP] -- Lightweight, RESTful DICOM server for healthcare and medical research
[remove ITP# since uploaded]
On Mon, Oct 8, 2012 at 5:22 PM, Sebastien Jodogne
<s.jodogne@chu.ulg.ac.be> wrote:
> Could someone explain how I could further improve the package? I thank you
> much in advance!
Well, I wasn't really happy about the following (but I uploaded anyway):
$ cat d/rules
...
override_dh_auto_install:
cp $(CURDIR)/Build/Orthanc $(CURDIR)/debian/orthanc/usr/bin/orthanc
gzip -c -9 $(CURDIR)/NEWS >
$(CURDIR)/debian/orthanc/usr/share/doc/orthanc/changelog.gz
What were you trying to do ?
Also I'll remove -DDEBIAN_HARDENING=ON on the next upload, I just do
not understand why it was used in the case of an explicit debian
packaging...
Not running the test suite is not a good idea.
Finally, I would not use -DCMAKE_BUILD_TYPE=Debug, maybe something
like MinSizeRel would be slightly better (-O2)
Thanks,
--
Mathieu
Reply to: