Re: Bug#689041: Re: Orthanc
Sébastien,
On Fri, Oct 5, 2012 at 6:35 PM, Mathieu Malaterre
<mathieu.malaterre@gmail.com> wrote:
> Why did you choose gnutls ? Your code seems to be using the openssl
> one. And your copyright is explicitely setup to deal with openssl
> exception anyway ?
Another set of minor comments.
1.
$ man -l -k docs/orthanc.1
docs/orthanc.1: nothing appropriate.
You can use help2man to quickly generate a proper man page.
2.
Some leftover:
$ more debian/copyright
[...]
Files: ThirdPartyDownloads/jsoncpp-src-0.5.0.tar.gz
Copyright: Baptiste Lepilleur <blep@users.sourceforge.net>
License: Public Domain
3.
d/changelog, one entry is enough.
4.
You can use quilt refresh to refresh dynamic-jsoncpp, to get rid of:
dpkg-source: warning: diff
`orthanc-0.2.2/debian/patches/dynamic-jsoncpp' patches file
orthanc-0.2.2/Resources/CMake/JsonCppConfiguration.cmake twice
Technically it would be nice to use DEP3 for patch, but I assume
'upstream' is aware of those ...
Thanks
--
Mathieu
Reply to: