Re: FreeDiams uploaded
Le 3 oct. 09 à 09:33, Andreas Tille a écrit :
On Fri, Oct 02, 2009 at 10:06:19PM +0200, Eric MAEKER wrote:
Script looks great, i've changed wget url. like this :
wget -q $URL
That's all.
Ahh, that's easy. ;-)
Yes, that's all me ;)
Comments to your upstream tarball in the first place:
- Please set the permissions of images (*.png) to not executable.
Lintian floods you with warnings about files with executable
permissions
which are not executable.
There are also some executable *.txt files in the tarball.
Oooops yes that's a problem with svn properties... I'll correct this.
- I also found some .DS_Store files in the tarball - I would also
remove
this.
Aaaahhhh MacOs... I love it ;)
- Please leave out the debian directory out of your upstream tarball.
Oh. debuilder includes debian/* files in autogenerated tarball ?
If so, I'll create my own tarball with my own command...
As you might see now yourself you have a difference between the
upstream tarball and the packaging stuff in SVN. This can easily
prevented by just not including the debian directory in the
upstream
tarball.
Yes, this error was not voluntary. And I'll correct this.
For the packaging I would split the data files into a separate
arch=all
package.
Oh yes, I'd like to do it myself but time is missing and documentation
for this kind of work is.... big...
But this is an issue.
There is some information about the reasons to do so in the
net which I do not want to repeat here. I'd happily volunteer to do
this change because I'm afraid that you are not as experienced than me
in this kind of stuff.
Eh eh ! You already know me well ;)
Yes thank you for all your help.
Can I add your contribution into the About page of FreeDiams/
FreeMedForms (including public mail) ?
I'd also add a freediams-doc package. I think I
might commit these changes today evening if you like this. You might
consider to apply my suggestions to your tarball meanwhile.
Hummm, I'm on holidays this night and off-line for one week. So yes,
I'll make changes since 12th of Octobre.
Kind regards and thanks for working on freediams
Thanks for your help !!!
Andreas.
Eric
Reply to: