Re: Update on WrapITK and debian

[Mathieu Malaterre <mathieu.malaterre@gmail.com>]

On Tue, Nov 24, 2009 at 8:09 AM, Steve M. Robbins <steve@sumost.ca> wrote:
> On Mon, Nov 23, 2009 at 06:45:06PM +0100, Mathieu Malaterre wrote:
>> Steve,
>>
>>   I thought I should give an update.
>>   I have been trying for the past weeks to get WrapITK working without
>> Review. I have to admit I never succeeded (see all my attempt
>> commented out in the patch file). I do not say it is not possible, I
>> am saying this is really hard.
>
> I didn't see the commented-out patch.  What is the difficulty?

You have to comment out entire groups. Filters are re-groupped
together assuming Review is ON.

@@ -0,0 +1,25 @@
+--- insighttoolkit-3.4.0.orig/Wrapping/WrapITK/CMakeLists.txt	2009-11-09
14:28:31.000000000 +0100
++++ insighttoolkit-3.4.0/Wrapping/WrapITK/CMakeLists.txt.old	2009-11-09
14:28:13.000000000 +0100
+@@ -145,8 +145,8 @@
+   Denoising
+   DistanceMap
+   EdgesAndContours
+-  FFT
+-  FFTW
++  #FFT
++  #FFTW
+   Filtering
+   IntensityFilters
+   Interpolators
+@@ -156,9 +156,9 @@
+   Morphology
+   #Patented
+   PixelMath
+-  Registration
++  #Registration
+   Resize
+-  Review
++  #Review
+   SegmentationAndThreshold
+   SegmentationValidation
+   SimpleFilters


Some filters even internally uses itkFlatStructuringElement or
itkKernelImageFilter to provide basic wrapping functionalities.

@@ -102,7 +112,8 @@
 get-orig-source: $(UPSTREAM_SRC).tar.gz
 	tar xzf $(UPSTREAM_SRC).tar.gz
 	find $(UPSTREAM_SRC) -name CVS -o -name Patented | xargs rm -rf
-	rm -rf $(UPSTREAM_SRC)/Code/Review
+	#rm -rf $(UPSTREAM_SRC)/Code/Review
+	#find $(UPSTREAM_SRC)/Code/Review -type f | grep -v
itkComposeRGBAImageFilter | grep -v itkFlatStructuringElement | grep
-v itkKernelImageFilter | grep -v itkSharedMorphologyUtilities |  grep
-v itkBoxImageFilter | grep -v itkVanHerkGilWermanDilateImageFilter |
grep -v itkVanHerkGilWermanErodeDilateImageFilter | grep -v
itkBresenhamLine | grep -v itkVanHerkGilWermanUtilities | xargs rm -rf
 	mv $(UPSTREAM_SRC) $(DEBIAN_SRC_DIR)
 	GZIP=-9 tar czf $(DEBIAN_SRC_TAR) $(DEBIAN_SRC_DIR)




> Could we get upstream help for this?

I have CC Gaetan, he mentionned that building without Review will be very hard.
The point being that at any time Review will be integrated into the
main source. Until REVIEW option is properly handled in WrapITK, I
think this will not be a task upstream will handle.


>> Let me know what you think of including Review in ITK.
>
> I'd really prefer not to do so, as Review provides no guarantee
> of license suitability nor stability.

Ok.

thanks,
-- 
Mathieu