Re: Getting -m64 at the right time and place.
Le Sat, Nov 15, 2008 at 12:51:48PM -0800, Russ Allbery a écrit :
> Charles Plessy <plessy@debian.org> writes:
>
> > Would the following patch make sense?
> >
> > diff --git a/configure.ac b/configure.ac
> > index ad2f1e6..4f2993a 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -23,10 +23,7 @@ case "${host_cpu}-${host_os}" in
> > AC_COMPILE_IFELSE([AC_LANG_PROGRAM], [ext_CFLAGS="-m64"], []);;
> > esac;;
> > *)
> > - AC_MSG_CHECKING([if gcc accepts -m64])
> > - CFLAGS="-m64"
> > - AC_COMPILE_IFELSE([AC_LANG_PROGRAM], [ext_CFLAGS="-m64"; AC_MSG_RESULT([yes])],
> > - [ext_CFLAGS="-D_FILE_OFFSET_BITS=64"; AC_MSG_RESULT([no])]);;
> > + ext_CFLAGS="-D_FILE_OFFSET_BITS=64";;
> > esac
> > AC_ARG_ENABLE(experimental, [ --enable-experimental enable experimental features],
> > [ext_CFLAGS="${ext_CFLAGS} -DMAQ_SHOW_EXPERIMENTAL"], [])
>
> The above change is probably fine, but the ideal solution would be for
> upstream to stop trying to code this directly and instead use the Autoconf
> macro provided for this purpose. AC_SYS_LARGEFILE will add to CFLAGS
> whatever flags are needed to enable large files. (Unfortunately, since
> upstream is using ext_CFLAGS instead of CFLAGS, you may not be able to
> just delete upstream's Autoconf code and add that macro.)
Thanks again everybody for your answers. I am using the patch and have
forwarded it Upstream.
http://sourceforge.net/tracker/index.php?func=detail&aid=2298601&group_id=191815&atid=938895
Have a nice day,
--
Charles Plessy
Debian Med packaging team,
Tsurumi, Kanagawa, Japan
Reply to: