[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New upload of emboss-explorer



Il giorno Sat, 29 Sep 2007 00:54:05 -0300
"Nelson A. de Oliveira" <naoliv@gmail.com> ha scritto:

> Hi David!

Hi,

> It's missing at least a "fi" closing the if in your script. Could you
> verify is something else is missing, please?

I've changed it to

[ ! $test ] || command

> (You can test your script with "sh -n do_cleanup.sh")
> Messages are different if using sh as bash or dash.

Done. :)

> Also, you could set the exec bit on your script, so you won't need to
> have "/bin/sh /usr/share/emboss-explorer/do_cleanup.sh" in your
> crontab file (you will be able to call it directly, without /bin/sh).
> And will make lintian happier too:
>
> W: emboss-explorer: script-not-executable
> ./usr/share/emboss-explorer/do_cleanup.sh
> N:
> N:   This file starts with the #! sequence that marks interpreted scripts,
> N:   but it is not executable.

Fixed :)
 
> Best regards,
> Nelson

Have a nice day,
David

-- 
 . ''`.  Debian maintainer | http://snipurl.com/gofoxygo/
 : :'  :  Linuxer #334216  |  http://www.hanskalabs.net/
 `. `'`    GPG: 1392B174   | http://www.debianizzati.org/
   `-   2BAB C625 4E66 E7B8 450A C3E1 E6AA 9017 1392 B174

Attachment: signature.asc
Description: PGP signature


Reply to: