[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New upload of emboss-explorer

Hi David!

On 9/28/07, David Paleino <d.paleino@gmail.com> wrote:
> Hi Nelson, sorry for the delay (Bogofilter needs some fine-tuning ;) )

No problem ;-)

> > It's missing do_cleanup.sh:
> Forgot to svn add it. It's fixed now ;)

It's missing at least a "fi" closing the if in your script. Could you
verify is something else is missing, please?

(You can test your script with "sh -n do_cleanup.sh")
Messages are different if using sh as bash or dash.

Also, you could set the exec bit on your script, so you won't need to
have "/bin/sh /usr/share/emboss-explorer/do_cleanup.sh" in your
crontab file (you will be able to call it directly, without /bin/sh).
And will make lintian happier too:

W: emboss-explorer: script-not-executable
N:   This file starts with the #! sequence that marks interpreted scripts,
N:   but it is not executable.

This one is just a suggestion, but the script needs to be verified.

Best regards,

Reply to: