[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: clickhouse - Please review

Anton Gladky wrote:

> […] feel free to deactivate some of the tests or in the worst-case
> scenario just disable them completely.

This is likely not easy in the specific case of clickhouse, but it is
often preferable to mark specific tests as "XFAIL" instead of removing
them entirely. This means that the test will still run (and its result
will still be reported in the logs), but a failure of that test will
not cause the entire build to fail.

The same could be said of disabling the testsuite as a whole: it may
be preferable to do the equivalent of appending "|| true" instead of
not running any of it. If you are using the autopkgtest facility, this
can be achieved by marking the test as "flaky".

(Replying for the edification of the list at large; pretty sure Anton
shares this view & knowledge.)

Best wishes,

     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk

Reply to: