Re: unclaiming packages claimed for 3 weeks or more (Re: november report)
On 2018-11-26 20:48:07, Holger Levsen wrote:
> On Fri, Nov 23, 2018 at 11:06:43AM -0500, Antoine Beaupré wrote:
>> $ ./bin/review-update-needed --exclude linux linux-4.9 --lts --unclaim 3w
>> [...]
>> Editing file to unclaim: salt
>>
>> I've pushed that, I hope it works for you.
>
> this indeed works, however I didnt find a way to ignore both linux and
> linux-4.9, neither "--exclude linux --exclude linux-4.9" nor "exclude
> linux,linux-4.9" nor a bunch of other combinations worked.
Did you try "--exclude linux linux 4.9"? That should work.
> Also, I found another small bug: when I used the script without
> --exclude option (and with --unclaim 3w --lts) it would currently
> unclaim salt, linux and linux-4.9, however the generated diff/edit is
> (with context lines removed)
>
> -linux (Ben Hutchings)
> +linux
> -linux-4.9 (Ben Hutchings)
> +linux
> -salt (Mike Gabriel)
> +salt
>
> while it should be:
>
> -linux (Ben Hutchings)
> +linux
> -linux-4.9 (Ben Hutchings)
> +linux-4.9
> -salt (Mike Gabriel)
> +salt
>
> (the diff is +linux-4.9 instead of twice +linux)
oops. fixed.
a.
--
Modern man has a kind of poverty of the spirit which stands
in great contrast to his remarkable scientific and technological
achievements. We've learned to walk in outer space and yet we
haven't learned to walk to earth as brothers and sisters.
- Martin Luther King, Jr.
Reply to: