On Fri, Nov 23, 2018 at 11:06:43AM -0500, Antoine Beaupré wrote:
> $ ./bin/review-update-needed --exclude linux linux-4.9 --lts --unclaim 3w
> [...]
> Editing file to unclaim: salt
>
> I've pushed that, I hope it works for you.
this indeed works, however I didnt find a way to ignore both linux and
linux-4.9, neither "--exclude linux --exclude linux-4.9" nor "exclude
linux,linux-4.9" nor a bunch of other combinations worked.
Also, I found another small bug: when I used the script without
--exclude option (and with --unclaim 3w --lts) it would currently
unclaim salt, linux and linux-4.9, however the generated diff/edit is
(with context lines removed)
-linux (Ben Hutchings)
+linux
-linux-4.9 (Ben Hutchings)
+linux
-salt (Mike Gabriel)
+salt
while it should be:
-linux (Ben Hutchings)
+linux
-linux-4.9 (Ben Hutchings)
+linux-4.9
-salt (Mike Gabriel)
+salt
(the diff is +linux-4.9 instead of twice +linux)
--
cheers,
Holger
-------------------------------------------------------------------------------
holger@(debian|reproducible-builds|layer-acht).org
PGP fingerprint: B8BF 5413 7B09 D35C F026 FE9D 091A B856 069A AA1C
Attachment:
signature.asc
Description: PGP signature