On Tue, 2018-01-09 at 09:44 +0100, Jochen Sprickerhof wrote: > Hi Chris, > > * Chris Lamb <lamby@debian.org> [2018-01-09 05:39]: > > Any update on this? :) > > I'm still unsure if adding isValidPath() is a ABI break: Adding a non-virtual member function or static member variable is not an ABI break. Deleting a static member variable (ZipCommon::ILLEGAL_PATH) is. Though I'd be surprised if any library users depend on this. Ben. > ++ static bool isValidPath(const std::string& path); > > https://anonscm.debian.org/cgit/collab-maint/poco.git/commit/?h=wheezy/CVE-2017-1000472&id=b131b35b6a4a84776654743f34965e2fe0ed2889 > > I tried to check with abi-dumper yesterday, but it refused to read the > debug files and I ran out of time trying to make it work. Could someone > give a definitive answer? Otherwise I would change it into a macro. Will > continue this evening. > > Cheers Jochen -- Ben Hutchings If at first you don't succeed, you're doing about average.
Attachment:
signature.asc
Description: This is a digitally signed message part