[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: bin/genDLA proposal: auto-commit requested DLA numbers (was: Re: [SECURITY] [DLA 265-1] unattended-upgrades security update)



Hi,

On Sun, 05 Jul 2015, Mike Gabriel wrote:
> I just looked at the patch and played with it a little.
> 
> Comments:
> 
>   o We maybe want to do an "svn update" before manipulating data/DLA/list
>     and data/dla-needed.txt file? Probably a minor thing, but it svn
> updating could
>     be handeled by the script, as well

No opinion here.

>   o I'd auto-generate a commit message, something like:
>     -m "reserve $IDMODE-$DAID for $PACKAGE"

Done.

>   o Also, the "warning" text message on screen is above the svn diff output.
> There it somehow
>     gets lost and "stayed unseen" for me, the first time I tested this
> patch. Maybe the warning
>     message should be right above the "Do you want to commit now?"
> question.(?)

Done.

And committed the result.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: http://www.freexian.com/services/debian-lts.html
Learn to master Debian: http://debian-handbook.info/get/


Reply to: