Bug#673207: /etc/default/rcS is perhaps a better place for FANCYTTY variable
On Mon, May 21, 2012 at 02:07:40PM +0200, Didier 'OdyX' Raboud wrote:
> Le 21.05.2012 13:47, Roger Leigh a écrit :
> > I'm not sure what you mean here. Do you plan to keep the definition
> > in two places (for backward compatibility?)? Which would be the
> > "preferred" location, i.e. which would take priority over the other?
>
> Given that /etc/lsb-base-logging.sh is a documented interface supposed
> to be a full-fledged shell script and that FANCYTTY is a single shell
> variable, I would rather opt for it to be in a simpler file such as
> /e/d/rcS.
>
> Then if people want to do funky stuff like conditional setting in
> /e/lsb-base-logging.sh, free to them. This file is not a conffile of
> lsb-base nor of any package AFAIK and is usually not present.
>
> >> ... with some maintainer script code in lsb-base and/or sysvinit to copy
> >> an existing value of FANCYTTY from /e/lsb-base-logging.sh to /e/d/rcS .
> >
> > Is this just on upgrade e.g. in the maintainer scripts? To be run just
> > once to migrate the setting? Or for all changes?
>
> Hmm; now that I think of it, it would be possible to simply have
> /etc/default/rcS ship an empty (or even commented) FANCYTTY= definition
> and let /etc/lsb-base-logging.sh untouched: if an admin added a FANCYTTY
> definition to his /e/lsb-base-logging.sh, then it would simply continue
> to work; if he hasn't too and future users would be pointed at /e/d/rcS.
> Nice.
Sounds ideal. And by default all values in /e/d/rcS are commented, at
least in current (experimental) versions.
So as discussed on #debian-devel, I'll do the following in initscripts:
- make /etc/default/rcS a conffile
- add FANCYTTY
- add FANCYTTY to rcS(5)
For the latter two, a paragraph describing what the setting does and
what its default value and possible other values are is needed; if
this could be provided, that would be great.
Regards,
Roger
--
.''`. Roger Leigh
: :' : Debian GNU/Linux http://people.debian.org/~rleigh/
`. `' schroot and sbuild http://alioth.debian.org/projects/buildd-tools
`- GPG Public Key F33D 281D 470A B443 6756 147C 07B3 C8BC 4083 E800
Reply to: