On Tue, May 01, 2012 at 09:45:44AM +0200, Didier 'OdyX' Raboud wrote: > Le 01.05.2012 07:42, Steve Langasek a écrit : > > My opinion is that this is best done in the single /lib/lsb/init-functions > > file. The filename is an interface defined in the LSB, but there's nothing > > in the LSB that says this interface can't provide additional shell > > functions; and having this all in a single place simplifies the interface > > for the Debian init scripts. And if you've followed the discussion on > > debian-devel, you know that there's quite a lot of interest in having > > simpler init scripts. :) > > If you decide not to include this patch in lsb/init-functions, then I guess > > I'll propose a new shell include as you describe; but I really don't think > > that's the best solution. > That's convincing enough for me. I just committed the attached patch and > will push it later today. I plan to upload it after the new Fancy output > (as 4.1+Debian1) will have reached testing, along with other stuff. > Thanks for your patch, cheers, Great, thanks! BTW, I'm sorry to say I've just noticed the patch I sent has a bug; the output of 'which initctl' should be suppressed, otherwise each init script using this function will output "/sbin/initctl" which we don't want. So the line should be: if which initctl >/dev/null && initctl version | grep -q upstart Sorry for the bug. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slangasek@ubuntu.com vorlon@debian.org
Attachment:
signature.asc
Description: Digital signature