Bug#884585: live-build: Grub autodetect option no longer works with 686 kernel
El 21/12/17 a las 14:32, Raphael Hertzog escribió:
> On Sun, 17 Dec 2017, adrian15 wrote:
>> * What led up to the situation?
>
> The reportbug templates are not always very appropriate when you
> just want to submit a patch... just go straight to the explanation
> of the patch and why it should be merged.
>
>> I attach a patch (that can be applied on current git head) that fixes
>> this bug by replacing the old 486 references
>> with the new 686 references in binary_loopback_cfg file.
>
> Applied. I also renamed the variables for consistency.
>
> Cheers,
>
Thank you for applying it.
Just for the record. I did not update those variables so that further
commits / pull requests around that code did work in a clean manner and
would not have to depend on a previous commit / patch of mine.
And, well, I somehow thought it did not matter too much. Actually
renaming them to X86 would be a better move.
But, then, you know there is 686 but... there hasn't been any 786
kernels so I don't think that variable will get renamed any where in the
future... so that's fine after all.
adrian15
--
Support free software. Donate to Super Grub Disk. Apoya el software
libre. Dona a Super Grub Disk. http://www.supergrubdisk.org/donate/
Reply to: