[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#884585: live-build: Grub autodetect option no longer works with 686 kernel



Package: live-build
Version: 1:20171207
Severity: normal
Control: tags -1 + patch

Dear Maintainer,


   * What led up to the situation?

I was trying to build a live cd that has both two kernels: 686 and amd64
and at the same time which would be any hybrid disk so that I can boot
in a BIOS-only machine and in an UEFI-only machine.

   * What exactly did you do (or not do) that was effective (or
     ineffective)?

I used these options:
--linux-flavours="686 amd64"
--bootloaders="syslinux,grub-efi"
to build my system.

   * What was the outcome of this action?

No autodetect menu was shown in grub.cfg / grub menu.

   * What outcome did you expect instead?

I expected an autotect menu to appear on grub.cfg / grub menu.

  * Patch attached

I attach a patch (that can be applied on current git head) that fixes
this bug by replacing the old 486 references
with the new 686 references in binary_loopback_cfg file.

You can also find the same patch at:
* Repo: https://github.com/rescatux/live-build.git
* Branch: loopback_cfg_686_kernel_support


-- System Information:
Debian Release: 9.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=es_ES.UTF-8, LC_CTYPE=es_ES.UTF-8 (charmap=UTF-8),
LANGUAGE= (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages live-build depends on:
ii  debootstrap  1.0.89

Versions of packages live-build recommends:
ii  apt-utils                       1.4.8
ii  cpio                            2.11+dfsg-6
pn  live-boot-doc                   <none>
pn  live-config-doc                 <none>
pn  live-manual-html | live-manual  <none>
ii  wget                            1.18-5+deb9u1

live-build suggests no packages.
>From 8e769fbc9c43cc1f52649f16b25e06f897a641c2 Mon Sep 17 00:00:00 2001
From: Adrian Gibanel Lopez <adrian.gibanel@btactic.com>
Date: Fri, 15 Dec 2017 18:27:48 +0000
Subject: [PATCH] Updated binary_loopback_cfg so that it uses Stretch's 686
 kernel instead of old 486 one.

---
 scripts/build/binary_loopback_cfg | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/build/binary_loopback_cfg b/scripts/build/binary_loopback_cfg
index 00f537c48..93c50f485 100755
--- a/scripts/build/binary_loopback_cfg
+++ b/scripts/build/binary_loopback_cfg
@@ -182,7 +182,7 @@ _AMD64_486_NUMBER="0"
 
 for _FLAVOUR in ${LB_LINUX_FLAVOURS}
 do
-	if [ "${_FLAVOUR}" = "amd64" -o "${_FLAVOUR}" = "486" ] ; then
+	if [ "${_FLAVOUR}" = "amd64" -o "${_FLAVOUR}" = "686" ] ; then
 		_AMD64_486_NUMBER="$((${_AMD64_486_NUMBER} + 1))"
 	fi
 done
@@ -191,7 +191,7 @@ if [ "${_AMD64_486_NUMBER}" -ge 2 ] ; then
 	# Default entries
 	AMD64_KERNEL="$(basename chroot/boot/vmlinuz-*amd64)"
 	AMD64_INITRD="initrd.img-$(echo ${AMD64_KERNEL} | sed -e 's|vmlinuz-||')"
-	_486_KERNEL="$(basename chroot/boot/vmlinuz-*486)"
+	_486_KERNEL="$(basename chroot/boot/vmlinuz-*686)"
 	_486_INITRD="initrd.img-$(echo ${_486_KERNEL} | sed -e 's|vmlinuz-||')"
 
 	Grub_live_autodetect_entry "Live system (autodetect)" \

Reply to: