[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#789300: cache.sh "if same device" check don't work with symlink




Subject: Support building image without root.
Package: live-build
Version: 5.0~a8-1
Severity: normal
Tags: upstream, patch

Dear Maintainer,

At the momemt I build my live build images inside a privileged docker container with Gitlab CI Multirunner.
I have attached a volume (/cache), and before I start "lb build" I symlink it.
The problem is cache.sh think it the same device, so it try to "hard link" copy, which of course don't work. (
Invalid cross-device link).
The problem seems to be that stat without a last slash, don't follow the symlink, but only check there the link is stored.

See for you self.
[kristian@arch-hp-laptop ~]$ mkdir test
[kristian@arch-hp-laptop
~]$ stat --printf '%d\n' test
2051
[kristian@arch-hp-laptop
~]$ ln -s /tmp symlink
[kristian@arch-hp-laptop ~]$ stat --printf '%d\n' /tmp
33
[kristian@arch-hp-laptop
~]$ stat --printf '%d\n' symlink
2051
[kristian@arch-hp-laptop
~]$ stat --printf '%d\n' symlink/
33

Patch attached.

 Regards Kristian Klausen -- Package-specific info: -- System Information: Debian Release: 8.0 APT prefers stable-updates APT policy: (500, 'stable-updates'), (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/1 CPU core) Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages live-build depends on: ii cdebootstrap 0.6.4 ii debootstrap 1.0.67 Versions of packages live-build recommends: ii cpio 2.11+dfsg-4.1 ii live-boot-doc 4.0.2-1 ii live-config-doc 4.0.4-1 ii live-manual-html [live-manual] 1:4.0.1-1 live-build suggests no packages. -- no debconf information

Attachment: symlink.patch
Description: Binary data


Reply to: