[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#656135: Add findiso boot parametre



On 04/08/2012 12:19 AM, adrian15 wrote:
> I rewrote the patch according to intrigeri wishes and with some pieces
> of advice from Daniel.

but now you did worsen it a bit compared to the last iteration :)

  * use 'mkdir -p /live/findiso' instead of 'mkdir /live/findiso -p'
    for consistency.

  * use 'if [ -d /live/findiso ] && [ ! -d /root/live/findiso ]'
    instead of 'if [ -d /live/findiso -a ! -d /root/live/findiso ]'
    which is a bashism.

  * don't use 'local' when declaring variables, it's a bashism.

other than that, looks good to me.

-- 
Address:        Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern
Email:          daniel.baumann@progress-technologies.net
Internet:       http://people.progress-technologies.net/~daniel.baumann/



Reply to: