[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#656135: Add findiso boot parametre



Hi,

adrian15 wrote (06 Apr 2012 17:23:45 GMT) :
> I think I've finally managed to make the patch.

Thank you.

> I've even improved the part about checking that the iso was mounted
> that intrigeri pointed out at:
> http://lists.debian.org/debian-live/2011/09/msg00067.html

So you have replaced

  grep -q /live/findiso /proc/mounts && umount /root/live/findiso

with

  [ ! -z ${mountpoint} ] && umount /root/live/findiso

It seems more fragile to me than what the original patch did (although
it did in a way I did not like); but maybe you can explain us why this
new check is sufficient and/or better suited than the old one?

Other than that, this patch is fine with me.

Regards,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc



Reply to: