Hi, I'm just looking at scripts/live:is_nice_device(), and I read: if /lib/udev/path_id "${sysfs_path}" | egrep -q "ID_PATH=(usb|pci-|platform-sata_mv|platform-orion-ehci|platform-mmc|platform-mxsdhci|)" then return 0 ... Nobody noticed that the regexp in egrep can be replaced by 'ID_PATH=' without changing semantics? The last branch in the |..|.. expression is empty, so whenever ID_PATH= matches, the full regexp matches. That's rather fortunate for me, since on the p2020 soc the usb controller has a strange id that won't match any of the branches anyways. cheers, David -- GnuPG public key: http://user.cs.tu-berlin.de/~dvdkhlng/dk.gpg Fingerprint: B17A DC95 D293 657B 4205 D016 7DEF 5323 C174 7D40
Attachment:
pgpguhJmA7LaC.pgp
Description: PGP signature