[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#643585: Bug 643585

Hash: SHA1

first some general things..

  * please clean your changes from useless whitespaces at EOL and EOF.

  * please use proper indenting and coding style to match the rest of
    live-build, see
    http://live.debian.net/manual/en/html/coding-style.html; lb is not
    100% consistent everywhere, but almost)

  * please keep logical seperated things in seperated patches,

- -»·····debian

    in the place where /etc/hosts is created, is perfectly fine,
    but has nothing to do with adding ubuntu cloud images and should
    be a seperate commit on it's own. there are a couple of other things
    like that that should be applied individually.

  * if you add new features/behaviour to existing helpers, don't break
    old behaviour. e.g.

- -   ls config/task-lists/*.list.chroot > /dev/null 2>&1 || \
- -   ls config/task-lists/*.list.chroot_${_PASS} > /dev/null 2>&1
+   ls config/task-lists/*.list.${_TARGET} > /dev/null 2>&1 || \
+   ls config/task-lists/*.list.${_TARGET}_${_PASS} > /dev/null 2>&1

     if we would do that, we would not just break existing configs
     (which sometimes is inevitable and ok-ish for development versions
     such as lb 3.x) but it would also mean, that now everyone has to
     define user overly complicated task list names for the default
     (!= your target thing) case.

     a proper way to do this is to do look for the additional files
     in addition, and still respect the other ones.

  * why do you add a new stage 'image' in the first place? producing
    ubuntu cloud images just means that's another binary image time
    alongside iso and hdd, not a whole new stage within live-build. in
    fact, i don't see why this cannot be done on top on hdd anyways.

  * do you happen to have a git tree online? it would probably be
    more convenient for both of us :)

i think it would be best if you do above things, then we apply all the
non-ubuntu-cloud-image related things (the misc fixes like the
/etc/hosts one), and then the big one for adding the ubuntu-cloud-images


- -- 
Address:        Daniel Baumann, Donnerbuehlweg 3, CH-3012 Bern
Email:          daniel.baumann@progress-technologies.net
Internet:       http://people.progress-technologies.net/~daniel.baumann/
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/


Reply to: