Bug#627183: live-build: minimal hook doesn't seem appropriate for Ubuntu
On Wed, May 18, 2011 at 07:47:51PM +0200, Daniel Baumann wrote:
> On 05/18/2011 03:43 PM, Colin Watson wrote:
> >it would be quite a hassle for us to rename our existing task now.
>
> it's not nice to rename it for debian too; however..
>
> >There doesn't seem to be any way to exclude a hook that happens to match
> >a task name, and since hooks get a stripped environment I wasn't able to
> >check LB_MODE in the hook itself either. Would something like the
> >attached patch be agreeable to you, or would you prefer some different
> >approach?
>
> ..i think it's worse to have l-b behave differently in that aspect
> depending on if its building debian or ubuntu.
Hmm. OK, perhaps ...
> any suggestion for a new name for 'minimal'?
There's substantial overlap with 'stripped'. Maybe 'reduced' or
'cleaned' or something.
Another approach would be to note that since there's no equivalent of
#include in package lists for tasks, it's more reasonable to use a
'minimal' task directly, and so 'minimal' could be excluded from
LB_HOOKS if it came from LB_TASKS. That wouldn't need to be
distribution-specific since there's no 'minimal' task for Debian.
Alternatively: we really only install the 'minimal' task as a safety
net, since debootstrap should already install all the same packages. If
you think that all of these options are too nasty, then we could just
drop the safety net and not bother to tell live-build to install the
'minimal' task, in which case we could close this bug.
Let me know what you prefer?
--
Colin Watson [cjwatson@ubuntu.com]
Reply to: