[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Expose build configuration during execution of chroot hooks



Hello,

On Sun, Nov 8, 2009 at 10:38 AM, Daniel Baumann <daniel@debian.org> wrote:
Cody A.W. Somerville wrote:
>  Please accept this simple patch that exposes build configuration to
> chroot hooks by copying the config directory to chroot/root/config and
> removing it before and after each hook is executed.

have you though about the fact, that some people are storing quite a log
of packages or data in directories within the config tree? apart from
that it could take considerable amount of additional time to copy
things, it also takes hdd space.

I did consider this for my use case and the benefits outweighed those concerns. However, since not everyone has the same needs as me I now imagine it would be wise for this to be configurable behavior.
 
> This allows for smarter hooks that are configurable.

what particular use case do you have in mind?

I build a large number of different images with varying configuration. I've developed a number of hooks to accomplish common tasks. I want to reuse these hooks and I want to maintain only a single version that is configurable based on project needs and/or automatically adjusts (ie. Just Works (TM) ) based on build configuration.

One example is being able to disable/enable OEM variant builds and configure which oem-config UI frontend to install via some variables in a configuration file I call 'project' instead of modifying the actual hook. Another example is configuring a hook I created to ubinize my chroots which requires details from config/chroot.

Cheers,
 
--
Cody A.W. Somerville
Software Systems Release Engineer
Foundations Team
Custom Engineering Solutions Group
Canonical OEM Services
Phone: +1-781-850-2087
Cell: +1-506-471-8402
Email: cody.somerville@canonical.com

Reply to: