[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#530126: live-helper: bashism in /bin/sh script



On Wednesday 08 July 2009 07:33:55 Daniel Baumann wrote:
> Version: 1.0.5-1
>
> If you reopen a bug, you should say why you think it's not fixed. I
> can't find any bashism in 1.0.5-1

I'm still seeing the same bashisms I originally reported (I'll let you reopen 
the report to avoid BTS ping-pong):

Processing Deb/mirror/pool/main/l/live-helper/live-helper_1.0.5-1_all.deb...
possible bashism in ./etc/cron.daily/live-helper line 38 ($HOST(TYPE|NAME)):
echo "$(date +%b\ %d\ %H:%M:%S) ${HOSTNAME} live-helper: begin daily build." 
>> /var/log/live
possible bashism in ./etc/cron.daily/live-helper line 154 ($HOST(TYPE|NAME)):
echo "$(date +%b\ %d\ %H:%M:%S) ${HOSTNAME} live-helper: end daily build." 
>> /var/log/live
done

The only file being sourced by that cron script 
is /etc/default/live-helper_autobuild, which doesn't contain a definition of 
HOSTNAME.

> (only a false positive about $HOSTNAME in debian/live-initramfs.init).

Are you sure? for -initramfs (1.157.2-1) what I get is:
possible bashism in ./etc/init.d/live-initramfs line 164 (echo -e):
                echo -n -e "\n\n${MESSAGE} and press ENTER to continue:" 
> /dev/console

You can use the following script to check a package for bashisms (it is very 
similar to the one I use on my archive-wide checks), it takes one or more 
file names as parameters: 
http://git.debian.org/?p=users/atomo64-guest/misc-devscripts.git;a=blob;f=checkbashisms-in-package.sh;hb=HEAD

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



Reply to: