[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: FTWCA storing config/ in VCS



On Fri, Jan 16, 2009 at 10:18:40PM -0500, Juergen Fiedler wrote:
> On Fri, Jan 16, 2009 at 9:59 AM, Daniel Baumann <daniel@debian.org> wrote:
> > I've improved this, the way config.cfg is handled is:
> >
> >  * if config.cfg is executed, its output is taken as extra arguments.
> [...]
> 
> It looks to me like the line that does this (I think it's line 719 in
> lh_config right now) should be
>   EXTRA_ARGUMENTS=$(./config.cfg)
> instead of
>   EXTRA_ARGUMENTS="./config.cfg"
> 
> It seems to fail for me otherwise.

Another small fix:

diff --git a/helpers/lh_config b/helpers/lh_config
index ef5b506..a491678 100755
--- a/helpers/lh_config
+++ b/helpers/lh_config
@@ -723,7 +723,7 @@ then
        EXTRA_ARGUMENTS="$(sed -e '/^$/d' -e '/^#/d' config.cfg | sed -e '$!N;s/
 fi

-Local_arguments "${EXTRA_ARGUMENTS} ${@}"
+Local_arguments ${EXTRA_ARGUMENTS} "${@}"

 if [ -n "${_CONFFILE}" ]
 then

Otherwise getopts in Local_arguments complains agout the first "parameter" 
(all the options config.cfg).

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen@xorcom.com
+972-50-7952406           mailto:tzafrir.cohen@xorcom.com
http://www.xorcom.com  iax:guest@local.xorcom.com/tzafrir


Reply to: