Bug in lh_mount_devpts

[daniel at debian.org (Daniel Baumann)]

Justin Pryzby wrote:
> On Sat, Dec 01, 2007 at 05:03:01PM +0100, Daniel Baumann wrote:
>> Otavio Salvador wrote:
>>>> -			if [ -e chroot/dev/pts/0 ]
>>>> +			if ls /dev/pts/[0-9] > /dev/null 2>&1
>>>                   chroot/dev/pts/* ?
>> both checks are insufficient, as they are always true.
> Really?

yes.

the check assumes, that if there is something in /dev/pts/*, then it has
to be unmounted. but there is always something in /dev/pts/*, regardless
if it is mounted, udev is running, or plain devices are used. therefore,
any check for existence of /dev/pts/* is insufficient.

(probably, it is sufficient on etch, but it's not on sid.)

-- 
Address:        Daniel Baumann, Burgunderstrasse 3, CH-4562 Biberist
Email:          daniel.baumann at panthera-systems.net
Internet:       http://people.panthera-systems.net/~daniel-baumann/