Bug in lh_mount_devpts

[jpryzby+d at quoininc.com (Justin Pryzby)]

On Sat, Dec 01, 2007 at 05:03:01PM +0100, Daniel Baumann wrote:
> Otavio Salvador wrote:
> >> -			if [ -e chroot/dev/pts/0 ]
> >> +			if ls /dev/pts/[0-9] > /dev/null 2>&1
> > 
> >                   chroot/dev/pts/* ?
> 
> both checks are insufficient, as they are always true.
Really?

$ ls pts/[0-9]* >&/dev/null ; echo $?
0
$ sudo umount pts
$ ls pts/[0-9]* >&/dev/null ; echo $?
2

(Noting that [0-9]* is a shell wildcard and not a regex, I think it's
the best possibility; hopefully devpts at least ensures that even if
something else exists here, it won't *begin* with a digit; note also
that >& is a bashism).

Justin