[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Enhancing lintian performance for large source packages



Hi,

On 2024-05-23 20:20, Russ Allbery wrote:
This is fantastic work.  Thank you!

:)

Given that the time share is still 32%, though, I'm going to make an
additional controversial suggestion: perhaps we should provide an easy
documented shorthand to tell Lintian to not run "expensive" checks, or
perhaps not those specific checks?  I know the -X flag already exists, but
I think people don't know how to find it or determine what to pass to it.
(The Lintian man page says to see the CHECKS section, but then contains no
CHECKS section.)

Right, '-X' could be used to skip specific checks. Missing CHECKS section seems like a bug to me.

As for checks in Lintian::Check::Files::SourceMissing, they can be optimized even more by checking only files with .js, .html, .xhtml and .xht extensions. Now it seems that all files are scanned for overlong lines, but only the aforementioned extensions throw lintian hints.

Personally, I have never found either of those checks useful to me as a
packager.  They're both a source of constant annoying false positives and
have never once alerted me to a problem that I didn't already know about.
I have considered, in the past, arguing that Lintian should remove them
entirely given how expensive they are and how prone to false positives
they are, but if there were some way that I could easily just opt out (and
of course assuming that ftp-master never rejects based on those checks),
that would relieve a lot of the pressure.

I personally find source-is-missing and source-contains-prebuilt-javascript-object useful. Most of the time I exclude such files and use Debian-provided ones instead (if available). This of course has its own risk of accidental use of incompatible versions.

Best,
Andrius


Reply to: