Bug#1033103: superficial-tests: false positive when both Testsuite + d/t/control are used

[Faidon Liambotis <paravoid@debian.org>]

On Fri, Mar 17, 2023 at 01:53:00PM +0200, Faidon Liambotis wrote:
> Indeed, autodep8 generates a file that has the manual tests combined
> with a pybuild-autopkgtest one. The pybuild-autopkgtest one is *not*
> marked as as superficial[1], as evident by the autodep8 output.
>
> 1: Debatable in this particular package, but besides the main point.

In case you go looking at the package to reproduce, note that in the
final upload to experimental I added extra_restrictions=superficial to
debian/tests/autopkgtest-pkg-pybuild.conf, so the autodep8 test will now
also be marked as superficial. In this case the lintian warning is
appropriate.

The bug however stands (it's present when autopkgtest-pkg-pybuild.conf
is not present). It can be reproduced by:
  apt source esptool=4.5.1+dfsg-0.1
  cd esptool*
  rm debian/tests/autopkgtest-pkg-pybuild.conf
  autodep8  # should list a d/t/control with a non-superficial test
  dpkg-buildpackage -S
  lintian ../esptool*dsc

Faidon