[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1033103: superficial-tests: false positive when both Testsuite + d/t/control are used



Source: lintian
Version: 2.116.3
Severity: normal

In the experimental branch of src:esptool, I've defined the following:
  * Testsuite: autopkgtest-pkg-pybuild in debian/control, to test the
    Python module. 
  * Three superficial tests in debian/tests/control to test the CLI
    tools using --help.

TTBOMK this is valid configuration. autodep8(1) has a section titled
"COMBINING AUTO-GENERATED TESTS WITH MANUALLY SPECIFIED ONES" to cover
this use case.

Indeed, autodep8 generates a file that has the manual tests combined
with a pybuild-autopkgtest one. The pybuild-autopkgtest one is *not*
marked as as superficial[1], as evident by the autodep8 output.

As another piece of evidence, autopkgtest reports:
  autopkgtest [13:39:27]: @@@@@@@@@@@@@@@@@@@@ summary
  smoke-esptool        PASS (superficial)
  smoke-espefuse       PASS (superficial)
  smoke-espsecure      PASS (superficial)
  pybuild-autopkgtest  PASS

However, lintian is warning about "superficial-tests", and says "The
source package declares tests in the debian/tests/control file but
provides only tests with a superficial restriction.".

It looks to me like a lintian bug, but let me know if I've misunderstood
something.

Regards,
Faidon

1: Debatable in this particular package, but besides the main point.


Reply to: