[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1003272: lintian: chokes on overrides with "(" but no ")"



unmerge 1003272
unmerge 1003353
unmerge 1007002
tag 1003272 + pending
notfound 1003272 2.114.123
retitle 1003353 lintian: Override processing defective for square brackets and curly brackets
notfound 1003353 2.114.0
severity 1007002 important
notfound 1007002 2.114.123
tag 1007002 + wontfix
kthxbye

Hi again,

I disagree that #1003272, #1003353 and #1007002 are the same bug. The
former two are similar, but not identical and the latter was only the
reason why the second one is showing up more often. Hence unmerging
all three.

Axel Beckert wrote in #1003272:
> Tobias Frost wrote:
> > Package: lintian
> > Version: 2.114.0
>
> Felix Lechner wrote:
> > On Fri, Jan 7, 2022 at 2:57 AM Tobias Frost <tobi@debian.org> wrote:
> > >
> > > Unmatched ( in regex; marked by <-- HERE in m/( <-- HERE
> > 
> > That is a consequence of switching to Text::Glob for overrides.
> 
> No. That feature only came _after_ 2.114.0 against which Tobias
> reported the bug:
> 
> https://salsa.debian.org/lintian/lintian/-/commit/139009d5a54225ebff4509ec37b979cb898c17fe

And it actually fixed Tobias' issue. I can reproduce Tobias' issue
with 2.114.0, but no more the current git HEAD (which is approximately
2.114.211, git commit 1c7bb81662e5e23a64fc272a008ddfc75c855537 or so).

> Ack. For the current version in git, I suggest using "?" or "*" to
> match problematic characters. E.g. for myself
> 
>   links2 source: very-long-line-length-in-source-file * > 512 *graphics/font/*
> 
> worked while
> 
>   links2 source: very-long-line-length-in-source-file * > 512 [graphics/font/*

This is actually #1003353 which claims that processing of parentheses
is broken, too, but actually only seems to be about brackets.

This issue is still present in the current git HEAD. Will handle that
one separately later.

And #1007002 is only (!) about design decision to change nearly all
tag formats involving file paths and line numbers. It has nothing to
do with the other two real bugs and I have no idea why they have been
merged.

While I was (and still am) annoyed by these changes, I do value the
goal behind it. I currently suspect that we're mostly through this
migration and I do hope that no such mass-changes will ever be needed
again. Especially since — as I wrote — the following will likely never
happen without Felix working on Lintian:

> > We will likely allow globbing on the file pointer, regular expressions
> > on the annotation and require literal matches for the tag name. To
> > keep those fields separate, we may switch to a Deb822 format for
> > override files, but hope to provide automated tools for migration and
> > management similar to those we already use internally to interactively
> > recalibrate Lintian's test suite.
> 
> Given that Felix quit working on Lintian, this will likely not happen
> unless someone steps up and continues the ideas and his work.
>
> I will only try to fix things for now. (And I'm not sure how I'll
> handle this, maybe mitigate it by more fitting documentation and
> maybe some sanity checks.)

Since at least I will not revert such huge changes, I'll tag #1007002
as "wontfix" for now and downgrade it to its original severity.

We can continue working on that bug report if we find someone who
either will work on reverting all the related work (although I think,
it's both, too late and also probably way too much work given all the
other recent changes) or, probably much better, provide either a
migration script or some code which also accepts the old override
formats. In that case, I'd remove the "wontfix" again. (Sorry, Simon,
I generally agree with #1007002, but we currently have way more severe
issues with Lintian than #1007002. Hence I also didn't remove the
confirmed tag.)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE

Attachment: signature.asc
Description: PGP signature


Reply to: