[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1003272: lintian: chokes on overrides with "(" but no ")"



Hi,

Tobias Frost wrote:
> Package: lintian
> Version: 2.114.0

Felix Lechner wrote:
> On Fri, Jan 7, 2022 at 2:57 AM Tobias Frost <tobi@debian.org> wrote:
> >
> > Unmatched ( in regex; marked by <-- HERE in m/( <-- HERE
> 
> That is a consequence of switching to Text::Glob for overrides.

No. That feature only came _after_ 2.114.0 against which Tobias
reported the bug:

https://salsa.debian.org/lintian/lintian/-/commit/139009d5a54225ebff4509ec37b979cb898c17fe

~/lintian/lintian → git describe
139009d5a54225ebff4509ec37b979cb898c17fe
2.114.0-32-g139009d5a

So it came 32 commits _after_ the 2.114.0 release. gitk confirms this
as well.

> We recently introduced 'pointed hints' which allow live links on our
> website to sources.d.o and soon others. In terminal output, they are
> shown as
> 
>     tag annotation [file pointer]
> 
> but that format is not great for overrides.

Ack. For the current version in git, I suggest using "?" or "*" to
match problematic characters. E.g. for myself

  links2 source: very-long-line-length-in-source-file * > 512 *graphics/font/*

worked while

  links2 source: very-long-line-length-in-source-file * > 512 [graphics/font/*

bailed out with a regexp syntax error, but now at
"/usr/share/perl5/Text/Glob.pm line 18", which might be actually a bug
in Text::Glob which does not seem to catch unproper shell bracket
wildcards.

> We will likely allow globbing on the file pointer, regular expressions
> on the annotation and require literal matches for the tag name. To
> keep those fields separate, we may switch to a Deb822 format for
> override files, but hope to provide automated tools for migration and
> management similar to those we already use internally to interactively
> recalibrate Lintian's test suite.

Given that Felix quit working on Lintian, this will likely not happen
unless someone steps up and continues the ideas and his work.

I will only try to fix things for now. (And I'm not sure how I'll
handle this, maybe mitigate it by more fitting documentation and
maybe some sanity checks.)

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe@debian.org>, https://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-    |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE


Reply to: