Bug#1007140: please have a check for chown user.group
On Sat, Mar 12, 2022 at 08:52:45AM -0800, Russ Allbery wrote:
> Marc Haber <mh+debian-packages@zugschlus.de> writes:
> > That regexp was copied verbatim from my codesearch search box. Did you
> > forget to switch the dropdown to "regex"?
>
> > The shadow package contains about ten of those constructs, for example
>
> > shadow_1:4.11.1+dfsg1-2/contrib/shadow-anonftp.patch
>
> > - fprintf (stderr, "%s: line %d: mkdir failed\n",
> > - Prog, line);
> > - else if (chown (newpw.pw_dir,
> > - newpw.pw_uid, newpw.pw_gid))
> > - fprintf (stderr, "%s: line %d: chown
> > failed\n",
>
> This specific example is a false positive, though, correct? I think you
> want to filter out hits that include a parenthesis, since those are likely
> to be calls to the C library function, which doesn't have this issue.
Of course, idiot me. I was not fully awake when I chose this example.
Greetings
Marc
--
-----------------------------------------------------------------------------
Marc Haber | "I don't trust Computers. They | Mailadresse im Header
Leimen, Germany | lose things." Winona Ryder | Fon: *49 6224 1600402
Nordisch by Nature | How to make an American Quilt | Fax: *49 6224 1600421
Reply to: