[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1007140: please have a check for chown user.group



Marc Haber <mh+debian-packages@zugschlus.de> writes:

> That regexp was copied verbatim from my codesearch search box. Did you
> forget to switch the dropdown to "regex"?

> The shadow package contains about ten of those constructs, for example

> shadow_1:4.11.1+dfsg1-2/contrib/shadow-anonftp.patch

> -    			fprintf (stderr, "%s: line %d: mkdir failed\n",
> -					Prog, line);
> -			else if (chown (newpw.pw_dir,
> -					newpw.pw_uid, newpw.pw_gid))
> -				fprintf (stderr, "%s: line %d: chown
> 				failed\n",

This specific example is a false positive, though, correct?  I think you
want to filter out hits that include a parenthesis, since those are likely
to be calls to the C library function, which doesn't have this issue.

-- 
Russ Allbery (rra@debian.org)              <https://www.eyrie.org/~eagle/>


Reply to: