[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#943536: marked as done (lintian: Stop shipping profile 'debian/ftp-master-auto-reject')

Your message dated Tue, 14 Dec 2021 07:14:05 -0800
with message-id <CAFHYt56DiDu7qmUSKwWYVHHhWqYRKJDYvGn3F5ub-HXQrzhhpA@mail.gmail.com>
and subject line Re: Bug#943536: lintian: Stop shipping profile 'debian/ftp-master-auto-reject'
has caused the Debian Bug report #943536,
regarding lintian: Stop shipping profile 'debian/ftp-master-auto-reject'
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
943536: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=943536
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: lintian
Severity: wishlist
X-Debbugs-CC: nthykier@debian.org, ftpmaster@debian.org

Hi,

Based on information from #debian-ftp, which is recorded in part below, the profile is no longer being used. It will be removed in the near future.

Please respond with objections.

Kind regards,
Felix Lechner

13:44 < 1> lechner: ftp master uses it's copy from the dak git repo. lintian is something else
13:54 < 1> dak calls lintian with it's own tags file, so the package included profile is not used
13:55 < lechner> i am not aware that lintian unstands the format of your file in https://salsa.debian.org/ftp-team/dak/blob/master/config/debian/lintian.tags
14:08 < 2> ... I think it's pretty obvious that file from dak's config is what's being used
14:09 < 2> config/debian/dak.conf: LintianTags "/srv/ftp-master.debian.org/dak/config/debian/lintian.tags";
14:10 < 2> which is then parsed by LintianCheck in daklib/checks.py to generate a file for lintian --tags-from-file
14:11 < 2> and daklib/lintian.py's generate_reject_messages looks at whether they were fatal or nonfatal in the YAML input to decide whether to allow overrides
14:12 < lechner> thanks for clarifying. i actually like that approach much better.
14:13 < lechner>  i will remove the auto-reject profile shipped with lintian in the near future.


--- End Message ---
--- Begin Message --- 
Hi,

On Mon, Nov 8, 2021 at 4:51 PM Felix Lechner <felix.lechner@lease-up.com> wrote:
>
> The idea behind this bug was too ambitious.

Lintian stopped shipping the FTP auto-reject profile in this commit.
[1] Instead we refresh [2] the tag list from FTP Master [3] before
each release, and use the data directly. [4] Aside from other
benefits, it simplified the release procedure. [5]

Closing the bug again, for good.

In the test suite, we currently enable three options together:

   --ftp-master-rejects --display-info --display-experimental

I'm not sure if the last two are needed, but I have yet to meet
someone who actually uses the -F command line option.

Kind regards
Felix Lechner

[1] https://salsa.debian.org/lintian/lintian/-/commit/3ad636e37a11dabe7063b66fbb1c8cd1321b53bb
[2] https://salsa.debian.org/lintian/lintian/-/blob/master/lib/Lintian/Data/Archive/AutoRejection.pm#L113-134
[3] https://ftp-master.debian.org/static/lintian.tags
[4] https://salsa.debian.org/lintian/lintian/-/blob/master/bin/lintian#L510-525
[5] https://salsa.debian.org/lintian/lintian/-/commit/3ad636e37a11dabe7063b66fbb1c8cd1321b53bb#8756c63497c8dc39f7773438edf53b220c773f67

--- End Message ---
Reply to: