[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#966140: send-patch does not detect upstream/backport keywords in Origin field



Package: lintian
Version: 2.84.0
Severity: normal
X-Debbugs-Cc: 

lintian complains that

I: rxvt-unicode source: send-patch debian/patches/13_document_modifiers.diff
N:
N:    According to the DEP-3 headers, this patch has not been forwarded
N:    upstream. Please forward the patch upstream and work with them to ensure
N:    the patch is included in the version control system and in the next
N:    upstream release of your package.

If we look at the DEP3 header of the patch [0], we see that the patch's
origin is the upstream project, and so the patch does not need to be
forwarded:

Description: Better document modifiers
Author: Emanuele Giaquinta
Origin: upstream, https://github.com/exg/rxvt-unicode/commit/b881e3714ba253d08dc1b900d9333b73759db126
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=839769
Last-Update: 2017-10-16

Indeed, the use of the "upstream" and "backport" keywords is defined in
the Origin field description on
https://dep-team.pages.debian.net/deps/dep3/ ,

    The field can be optionaly prefixed with a single keyword followed
    by a comma and a space to categorize the origin. The allowed
    keywords are "upstream" (in the case of a patch cherry-picked from
    the upstream VCS), "backport" (in the case of an upstream patch that
    had to be modified to apply on the current version), "vendor" for a
    patch created by Debian or another distribution vendor, or "other"
    for all other kind of patches.

lintian should recognize these two keywords.

[0] https://salsa.debian.org/debian/rxvt-unicode/-/blob/master/debian/patches/13_document_modifiers.diff


-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_CA.UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages lintian depends on:
ii  binutils                      2.34.90.20200706-1
ii  bzip2                         1.0.8-4
ii  diffstat                      1.63-1
ii  dpkg                          1.20.5
ii  dpkg-dev                      1.20.5
ii  file                          1:5.38-5
ii  gettext                       0.19.8.1-10
ii  gpg                           2.2.20-1
ii  intltool-debian               0.35.0+20060710.5
ii  libapt-pkg-perl               0.1.36+b3
ii  libarchive-zip-perl           1.68-1
ii  libcapture-tiny-perl          0.48-1
ii  libclass-xsaccessor-perl      1.19-3+b5
ii  libclone-perl                 0.45-1
ii  libconfig-tiny-perl           2.24-1
ii  libcpanel-json-xs-perl        4.19-1
ii  libdata-validate-domain-perl  0.10-1
ii  libdevel-size-perl            0.83-1+b1
ii  libdpkg-perl                  1.20.5
ii  libemail-address-xs-perl      1.04-1+b2
ii  libfile-basedir-perl          0.08-1
ii  libfile-find-rule-perl        0.34-1
ii  libfont-ttf-perl              1.06-1
ii  libhtml-parser-perl           3.72-5
ii  libio-async-loop-epoll-perl   0.21-1
ii  libio-async-perl              0.77-3
ii  libjson-maybexs-perl          1.004002-1
ii  liblist-compare-perl          0.53-1
ii  liblist-moreutils-perl        0.416-1+b5
ii  liblist-utilsby-perl          0.11-1
ii  libmoo-perl                   2.004000-1
ii  libmoox-aliases-perl          0.001006-1
ii  libnamespace-clean-perl       0.27-1
ii  libpath-tiny-perl             0.114-1
ii  libsereal-decoder-perl        4.017+ds-1
ii  libsereal-encoder-perl        4.017+ds-1
ii  libtext-levenshteinxs-perl    0.03-4+b7
ii  libtext-xslate-perl           3.5.8-1
ii  libtime-duration-perl         1.21-1
ii  libtime-moment-perl           0.44-1+b2
ii  libtimedate-perl              2.3300-1
ii  libtry-tiny-perl              0.30-1
ii  libtype-tiny-perl             1.010002-1
ii  libunicode-utf8-perl          0.62-1+b1
ii  liburi-perl                   1.76-2
ii  libxml-libxml-perl            2.0134+dfsg-2
ii  libxml-writer-perl            0.625-1
ii  libyaml-libyaml-perl          0.82+repack-1
ii  man-db                        2.9.3-2
ii  patchutils                    0.4.2-1
ii  perl [libdigest-sha-perl]     5.30.3-4
ii  t1utils                       1.41-4
ii  xz-utils                      5.2.4-1+b1

Versions of packages lintian recommends:
ii  libperlio-gzip-perl  0.19-1+b6

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  libtext-template-perl  1.59-1

-- no debconf information

-- 
|)|/  Ryan Kavanagh      | GPG: 4E46 9519 ED67 7734 268F
|\|\  https://rak.ac     |      BD95 8F7B F8FC 4A11 C97A

Attachment: signature.asc
Description: PGP signature


Reply to: