[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#964111: dpkg-source: False positive 'points outside source root'



Hi Guillem,

On Fri, Jul 3, 2020 at 9:54 PM Guillem Jover <guillem@debian.org> wrote:
>
> As long as the autopkgtests show regressions for the involved packages

>From Lintian's perspective, this bug is now resolved. After some
changes on our side, Lintian builds in unstable (without a new upload
of dpkg). I would normally close the bug, but did not wish to
interfere with Holger's matter below.

>From our Salsa job #850167:

debian/test-out/eval/checks/files/encoding/testsuite-in-western-encoding/generic.t
................................................. ok
debian/test-out/eval/checks/testsuite/national-encoding/generic.t
.................................................................. ok
debian/test-out/eval/checks/testsuite/testsuite-general/generic.t
.................................................................. ok

> there
> are still other regressions being dealt with…

The following information could be helpful to you: I initially thought
that Bug#964234 ("dpkg-source: Considers missing symlink targets
directory traversals") was the same, but I am no longer sure. More
significantly, our test suite no longer reproduces the other bug.

The three tests mentioned earlier all create links with missing
symlink targets in source packages, but do not FTBFS (or perhaps
succeed now for unrelated reasons).

    ln -s nonexistent "$DIR/debian/tests/broken"

I attached one of the packages for you.

> not sure if this is the same bug or just a similar one:
> lrwxrwxrwx 1 user user 9 Jul  3 16:07 debian/munin.service -> /dev/null

As for Holger's package, Lintian also flags that condition. Source
packages can be unpacked anywhere. We likewise consider absolute
symlink targets unacceptable there.

W: munin source: absolute-symbolic-link-target-in-source
debian/munin.service -> /dev/null

Hope this helps!

Kind regards
Felix Lechner

Attachment: testsuite-general_1.0.dsc
Description: Binary data

Attachment: testsuite-general_1.0.tar.xz
Description: Binary data


Reply to: